This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(core): property initialization #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes invalid native property initialization causing exception with certain custom elements. - closes vmware-archive#6589 - closes vmware-archive#6590 Signed-off-by: Cory Rylan <splintercode.cb@gmail.com>
hippee-lee
approved these changes
Jan 25, 2022
mathisscott
approved these changes
Jan 25, 2022
14 tasks
ashleyryan
approved these changes
Jan 25, 2022
This was referenced Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some custom elements fail to instantiate due to a property being set to early in its life cycle. If a native built in property is set that reflects its attribute before the element has been added to the DOM it can throw an exception in some browsers.
See references
https://stackoverflow.com/questions/43836886/failed-to-construct-customelement-error-when-javascript-file-is-placed-in-head
https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-conformance
closes [@core/react] NotSupportedError Failed to construct 'CustomElement': The result must not have attributes #6589
closes [@Cds/Card] Uncaught DOMException: Failed to construct 'CustomElement': The result must not have attributes #6590
What is the new behavior?
This moves the property to be set in the connectedCallback to prevent the exception. Unfortunately I could not find a great way to test this since this is a life cycle issue controlled by the browser. This will need to be backported to v5
Does this PR introduce a breaking change?
Other information