This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(react): fix jsdom react testing issues #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleyryan
force-pushed
the
topic/jsdom
branch
from
d9537b6
to
300217e
Compare
|
I repurposed the repo-clarity-proxy-set-disabled repo to test the fixes using RTL and they work now with yalc: https://github.com/ashleyryan/repro-clarity-proxy-set-disabled/blob/main/test.test.tsx |
ashleyryan
force-pushed
the
topic/jsdom
branch
from
300217e
to
f63d2bc
Compare
mathisscott
suggested changes
Feb 1, 2022
ashleyryan
force-pushed
the
topic/jsdom
branch
from
f63d2bc
to
53911aa
Compare
mathisscott
suggested changes
Feb 1, 2022
Fixes vmware#5985 - Add isNode check to property syncing in cdscontrol. Fixes vmware#6525: - Remove isNode check for aria-reflect, now that all roles are set in connectedCallback Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan
force-pushed
the
topic/jsdom
branch
from
53911aa
to
2f4da4b
Compare
mathisscott
approved these changes
Feb 1, 2022
coryrylan
approved these changes
Feb 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5985
Fixes #6525:
Signed-off-by: Ashley Ryan asryan@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue #5985
When rendering
CdsSelectin jsdom (via react-testing-library), an exception will be thrown on render and all tests will fail.Issue #6525
The aria-reflect polyfill doesn't run in node because of jsdom exceptions, meaning react unit tests can't target elements by
roleWhat is the new behavior?
Does this PR introduce a breaking change?
Other information