Integrate replica asks to leave view msg in replica status msg #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HristoStaykov
requested review from
andrewjstone,
f-squirrel,
teoparvanov and
yontyon
teoparvanov
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
LGTM, thanks! @yontyon could you also have a look, as this PR addresses a concern you had raised about the safety of the view change protocol modifications?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Status Reports Replicas indicate from which peers they have complaints for the View they are in.
By doing so peers are able to send them the complaints (ReplicaAsksToLeaveViewMSg-s) they are missing.
Resending of the complaint is disabled, because it can be resend during Status Reports.