Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RocksDB memory usage metrics: #2942

Merged
merged 1 commit into from Apr 17, 2023

Conversation

hshomroni
Copy link
Contributor

Motivation:

Investigations showed rocksDB mem consumption is major and keep increasing over time. These new metrics will help analyze rocksDB's mem usage and over consumption.

content:

  • added 5 metrics: total RAM usage, block caches, table readers (indexes and filters), mem tables and unflushed mem tables.
  • updates metrics and prints report to log.
  • currently hard coded to run every one minute

Copy link
Contributor

@glevkovich glevkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with some minor comments.
Thanks!

storage/include/memorydb/client.h Outdated Show resolved Hide resolved
storage/include/memorydb/client.h Show resolved Hide resolved
storage/include/rocksdb/client.h Outdated Show resolved Hide resolved
storage/include/rocksdb/client.h Show resolved Hide resolved
storage/include/rocksdb/client.h Show resolved Hide resolved
storage/include/storage/storage_metrics.h Outdated Show resolved Hide resolved
storage/include/storage/storage_metrics.h Outdated Show resolved Hide resolved
storage/include/storage/storage_metrics.h Outdated Show resolved Hide resolved
storage/include/storage/storage_metrics.h Outdated Show resolved Hide resolved
storage/src/rocksdb_client.cpp Outdated Show resolved Hide resolved
@hshomroni hshomroni force-pushed the hshomroni/rocksdb_mem_monitoring branch 3 times, most recently from b517282 to 71ba52b Compare February 27, 2023 08:18
@hshomroni hshomroni closed this Feb 27, 2023
@hshomroni hshomroni force-pushed the hshomroni/rocksdb_mem_monitoring branch from 71ba52b to 9ceee52 Compare February 27, 2023 11:21
@hshomroni hshomroni reopened this Mar 3, 2023
@hshomroni hshomroni force-pushed the hshomroni/rocksdb_mem_monitoring branch from b51fd5e to e2ee094 Compare March 14, 2023 13:30
@hshomroni hshomroni force-pushed the hshomroni/rocksdb_mem_monitoring branch 2 times, most recently from 818feb3 to 78fea7a Compare April 3, 2023 06:58
@hshomroni hshomroni force-pushed the hshomroni/rocksdb_mem_monitoring branch from 30ff108 to 78b2791 Compare April 10, 2023 06:34
- added 5 metrics: total RAM usage, block caches, table readers (indexes and filters), mem tables and unflushed mem tables.
- updates metrics and prints report to log.
- currently hard coded to run every one minute
@hshomroni hshomroni force-pushed the hshomroni/rocksdb_mem_monitoring branch from 2ad9c2b to 7c45969 Compare April 16, 2023 06:22
@hshomroni hshomroni merged commit 613ab23 into vmware:master Apr 17, 2023
4 checks passed
mdarade pushed a commit to mdarade/concord-bft that referenced this pull request May 1, 2023
- added 5 metrics: total RAM usage, block caches, table readers (indexes and filters), mem tables and unflushed mem tables.
- updates metrics and prints report to log.
- currently hard coded to run every one minute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants