-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RocksDB memory usage metrics: #2942
Merged
hshomroni
merged 1 commit into
vmware:master
from
hshomroni:hshomroni/rocksdb_mem_monitoring
Apr 17, 2023
Merged
add RocksDB memory usage metrics: #2942
hshomroni
merged 1 commit into
vmware:master
from
hshomroni:hshomroni/rocksdb_mem_monitoring
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshomroni
requested review from
titusen,
Efrat1,
cloudnoize,
yuliasherman,
glevkovich and
eyalrund
February 21, 2023 18:29
eyalrund
approved these changes
Feb 22, 2023
glevkovich
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with some minor comments.
Thanks!
hshomroni
force-pushed
the
hshomroni/rocksdb_mem_monitoring
branch
3 times, most recently
from
February 27, 2023 08:18
b517282
to
71ba52b
Compare
hshomroni
force-pushed
the
hshomroni/rocksdb_mem_monitoring
branch
from
February 27, 2023 11:21
71ba52b
to
9ceee52
Compare
hshomroni
force-pushed
the
hshomroni/rocksdb_mem_monitoring
branch
from
March 14, 2023 13:30
b51fd5e
to
e2ee094
Compare
hshomroni
force-pushed
the
hshomroni/rocksdb_mem_monitoring
branch
2 times, most recently
from
April 3, 2023 06:58
818feb3
to
78fea7a
Compare
hshomroni
force-pushed
the
hshomroni/rocksdb_mem_monitoring
branch
from
April 10, 2023 06:34
30ff108
to
78b2791
Compare
- added 5 metrics: total RAM usage, block caches, table readers (indexes and filters), mem tables and unflushed mem tables. - updates metrics and prints report to log. - currently hard coded to run every one minute
hshomroni
force-pushed
the
hshomroni/rocksdb_mem_monitoring
branch
from
April 16, 2023 06:22
2ad9c2b
to
7c45969
Compare
mdarade
pushed a commit
to mdarade/concord-bft
that referenced
this pull request
May 1, 2023
- added 5 metrics: total RAM usage, block caches, table readers (indexes and filters), mem tables and unflushed mem tables. - updates metrics and prints report to log. - currently hard coded to run every one minute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Investigations showed rocksDB mem consumption is major and keep increasing over time. These new metrics will help analyze rocksDB's mem usage and over consumption.
content: