ovsdb2ddlog: Add --intern-table CLI switch. #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `--intern-table` flag to the compiler to declare input tables coming from OVSDB as `Intern<...>`. This is useful for tables whose records are copied around as a whole and can therefore benefit from interning performance- and memory-wise. In the past we had to create a separate table and copy records from the original input table to it while wrapping them in `Intern<>`. With this change, we avoid the extra copy and intern records as we ingest them for selected tables. I am not pushing any tests for the new feature with this commit. Testing was done using the master branch of OVN that currently has a bunch of nondet test failures, presumably due to race conditions in the test harness.
blp
approved these changes
Mar 11, 2021
We don't have any documentation at the moment apart from the usage message printed by the compiler and a detailed comment in the Haskell source. There should probably be a separate file in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--intern-tableflag to the compiler to declare input tables coming fromOVSDB as
Intern<...>. This is useful for tables whose records are copiedaround as a whole and can therefore benefit from interning performance- and
memory-wise. In the past we had to create a separate table and copy records
from the original input table to it while wrapping them in
Intern<>. Withthis change, we avoid the extra copy and intern records as we ingest them
for selected tables.
I am not pushing any tests for the new feature with this commit.
Testing was done using the master branch of OVN that currently has a
bunch of nondet test failures, presumably due to race conditions in the
test harness.