Test to verify add, remove and replace of a vm from the _DEFAULT tenant #1283

ashahi1 · 2017-05-22T20:06:56Z

Test Steps:

Add a vm to the _DEFAULT tenant
Remove a vm from the _DEFAULT tenant
Replace a vm from the _DEFAULT tenant

Please refer Issue #1125

Output:

----TestAddRmvReplaceVmToTenant  Starts-------
2017/05/22 20:03:36 Adding VM [ubuntu-VM0.3] to a vmgroup [_DEFAULT] on esx [10.161.233.63]
2017/05/22 20:03:37 Not able to add a vm to the _DEFAULT tenant
2017/05/22 20:03:37 Removing VM [ubuntu-VM0.3] from a vmgroup [_DEFAULT] on esx [10.161.233.63]
2017/05/22 20:03:37 Not able to remove a vm from the _DEFAULT tenant
2017/05/22 20:03:37 Replacing VM [ubuntu-VM0.3] from a vmgroup [_DEFAULT] on esx [10.161.233.63]
--- PASS

pshahzeb

Looks good.
Some changes for code placement, logging

pshahzeb · 2017-05-22T21:45:43Z

tests/constants/admincli/cmd.go


 	// vmdkops_admin volume
-	vmdkopsAdminVolume = vmdkopsAdmin + "volume "
+	VmdkopsAdminVolume = VmdkopsAdmin + "volume "


these consts are local. you can define more consts that in turn use these...

Yes. These constants are intentionally kept starting with small case, because they are not meant to be exported.

pshahzeb · 2017-05-22T21:47:21Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+	expctdErr = "This feature is not supported for vmgroup _DEFAULT."
+)
+
+type AddRmvReplaceTestSuite struct {


DefaultTenantTestSuite may be? or anything better than. this name doesn't tell much about the test suite

+1. The struct name should be a noun.

pshahzeb · 2017-05-22T21:48:49Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+// 2. Remove a vm from the _DEFAULT tenant
+// 3. Replace a vm from the _DEFAULT tenant
+func (s *AddRmvReplaceTestSuite) TestAddRmvReplaceVmToTenant(c *C) {
+	log.Printf("----TestAddRmvReplaceVmToTenant  Starts------- ")


i think we can follow a logging standard here.
Something like this
log.Printf("START: basic-test.TestVolumeLifecycle")

+1. Let's follow a convention for tracing logs.

pshahzeb · 2017-05-22T21:49:52Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+// 3. Replace a vm from the _DEFAULT tenant
+func (s *AddRmvReplaceTestSuite) TestAddRmvReplaceVmToTenant(c *C) {
+	log.Printf("----TestAddRmvReplaceVmToTenant  Starts------- ")
+	out, err := vmgroup.AddVmToVmgroup(s.esxName, "_DEFAULT", s.hostName)


nit: put _DEFAULT in constants package

pshahzeb · 2017-05-22T21:55:30Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+	c.Assert(err, IsNil, Commentf(misc.FormatOutput(out)))
+	c.Assert(strings.TrimRight(string(out), "\n"), Equals, expctdErr, Commentf("ERROR: "+
+		"Able to add vm to the _DEFAULT tenant"))
+	log.Printf("Not able to add a vm to the _DEFAULT tenant")


we don't need this printfs. Assert passed itself means that we weren't able to add vm to default tenant( and that is the intention of the test). Trying to keep logs clean.

pshahzeb · 2017-05-22T21:57:08Z

tests/utils/vmgroup/vmgrouplifecycle.go

+// DeleteVmgroup method deletes a vmgroup and removes its volumes as well
+func DeleteVmgroup(ip, name string) ([]byte, error) {
+    log.Printf("Deleting a vmgroup [%s] on esx [%s]\n", name, ip)
+    return ssh.InvokeCommand(ip, admincli.VmdkopsAdmin+" vmgroup rm --name=" + name + " --remove-volumes")


these vmgroup operations (rm, add, create) can be declared as constants

pshahzeb · 2017-05-22T21:59:20Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+	out, err = vmgroup.RemoveVmFromVmgroup(s.esxName, "_DEFAULT", s.hostName)
+	c.Assert(err, IsNil, Commentf(misc.FormatOutput(out)))
+	c.Assert(strings.TrimRight(string(out), "\n"), Equals, expctdErr, Commentf("ERROR: "+
+		"Able to remove vm from the _DEFAULT tenant"))


"Able to remove vm from the _DEFAULT tenant" sounds positive.
Can we have a negative message since it would be printed in case when the assert failed i.e. you got something different from the expected error defined by var "expctdErr"

shaominchen

Can we rename "addremoverereplacevmtodefaulttenant_test" to something like "default_tenant_test"?

shaominchen · 2017-05-23T00:33:41Z

tests/constants/admincli/cmd.go


 	// vmdkops_admin volume
-	vmdkopsAdminVolume = vmdkopsAdmin + "volume "
+	VmdkopsAdminVolume = VmdkopsAdmin + "volume "


Yes. These constants are intentionally kept starting with small case, because they are not meant to be exported.

shaominchen · 2017-05-23T00:34:28Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

@@ -0,0 +1,67 @@
+//
+//    http://www.apache.org/licenses/LICENSE-2.0


We should have VMware copyright info here.

Pls. change file name to a small one like defaultvmgroup.go, #1262 is also adding tests for the default tenant and may make it into this file vs. a file for each test.

yeah agree .. one suggestion though defaultvmgroup_test.go instead

I have re-named it as defaultvmgroup_test.go

shaominchen · 2017-05-23T00:35:19Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+// limitations under the License.
+
+// This test tries to add, remove and replace vm to the _DEFAULT tenant.
+// Expected behavior is that add/rmv/replace vms for _DEFAULT vmgroup should fail.


Nit: rmv => rm

shaominchen · 2017-05-23T00:38:59Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+)
+
+const (
+	expctdErr = "This feature is not supported for vmgroup _DEFAULT."


Nit: Let's avoid using uncommon abbreviations - "expctd" looks weird. We can rename this to something like ErrorMsg.

shaominchen · 2017-05-23T00:39:57Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+	expctdErr = "This feature is not supported for vmgroup _DEFAULT."
+)
+
+type AddRmvReplaceTestSuite struct {


+1. The struct name should be a noun.

shaominchen · 2017-05-23T00:41:13Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+// 2. Remove a vm from the _DEFAULT tenant
+// 3. Replace a vm from the _DEFAULT tenant
+func (s *AddRmvReplaceTestSuite) TestAddRmvReplaceVmToTenant(c *C) {
+	log.Printf("----TestAddRmvReplaceVmToTenant  Starts------- ")


+1. Let's follow a convention for tracing logs.

shaominchen · 2017-05-23T00:42:31Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+	c.Assert(err, IsNil, Commentf(misc.FormatOutput(out)))
+	c.Assert(strings.TrimRight(string(out), "\n"), Equals, expctdErr, Commentf("ERROR: "+
+		"Able to add vm to the _DEFAULT tenant"))
+	log.Printf("Not able to add a vm to the _DEFAULT tenant")


shaominchen · 2017-05-23T01:00:07Z

tests/utils/vmgroup/vmgrouplifecycle.go

+// DeleteVmgroup method deletes a vmgroup and removes its volumes as well
+func DeleteVmgroup(ip, name string) ([]byte, error) {
+    log.Printf("Deleting a vmgroup [%s] on esx [%s]\n", name, ip)
+    return ssh.InvokeCommand(ip, admincli.VmdkopsAdmin+" vmgroup rm --name=" + name + " --remove-volumes")


shaominchen · 2017-05-23T01:05:35Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+// 1. Add a vm to the _DEFAULT tenant
+// 2. Remove a vm from the _DEFAULT tenant
+// 3. Replace a vm from the _DEFAULT tenant
+func (s *AddRmvReplaceTestSuite) TestAddRmvReplaceVmToTenant(c *C) {


I'd suggest to rename this to TestModifyDefaultTenantVMs. Basically the intention is to verify whether modifying default tenant VMs is allowed or not.

shuklanirdesh82 · 2017-05-23T05:44:56Z

tests/constants/admincli/cmd.go


 	// ListVolumes referring to vmdkops_admin volume ls
-	ListVolumes = vmdkopsAdminVolume + "ls "
+	ListVolumes = VmdkopsAdminVolume + "ls "


need to revert this back.

shuklanirdesh82 · 2017-05-23T05:46:06Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+)
+
+const (
+	expctdErr = "This feature is not supported for vmgroup _DEFAULT."


I would suggest to move such constant to dedicated constant file

shuklanirdesh82 · 2017-05-23T05:46:43Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+)
+
+type AddRmvReplaceTestSuite struct {
+	esxName  string


esxName => esxIP .. we are exporting IPs not Names.

Please take care about the refactoring if you find such kind of variables into other files.

shuklanirdesh82 · 2017-05-23T05:46:50Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+
+type AddRmvReplaceTestSuite struct {
+	esxName  string
+	hostName string


same as above

shuklanirdesh82 · 2017-05-23T05:48:18Z

tests/e2e/addremoverereplacevmtodefaulttenant_test.go

+}
+
+func (s *AddRmvReplaceTestSuite) SetUpTest(c *C) {
+	s.hostName = govc.RetrieveVMNameFromIP(os.Getenv("VM1"))


let's use VM2 .. until we fix photon related issue to retrieve vmname from IP using govc

yes...good one!

shuklanirdesh82 · 2017-05-23T05:54:40Z

tests/utils/vmgroup/vmgrouplifecycle.go

+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// This util is going to hold various helper methods related to vmgroup to be consumed by testcases.


"is going to hold" => holds

shuklanirdesh82 · 2017-05-23T05:56:54Z

tests/utils/vmgroup/vmgrouplifecycle.go

+// vmgroup creation, deletion is supported as of now.
+
+
+package vmgroup


hmmmm...ok!

shuklanirdesh82 · 2017-05-23T06:00:02Z

tests/utils/vmgroup/vmgrouplifecycle.go

+
+
+// CreateVmgroup method is going to create a vmgroup and adds vm to it
+func CreateVmgroup(ip, name string, vmName string) ([]byte, error) {


ip, name string, vmName string => ip, name, vmName string .. to keep it consistent

shuklanirdesh82 · 2017-05-23T06:00:50Z

tests/utils/vmgroup/vmgrouplifecycle.go

+// CreateVmgroup method is going to create a vmgroup and adds vm to it
+func CreateVmgroup(ip, name string, vmName string) ([]byte, error) {
+    log.Printf("Creating a vmgroup [%s] on esx [%s]\n", name, ip)
+    return ssh.InvokeCommand(ip, admincli.VmdkopsAdmin+" vmgroup create --name="+name + " --default-datastore=\"_VM_DS\" --vm-list=" + vmName)


to keep it consistent ... command should be placed at const file

shuklanirdesh82 · 2017-05-23T06:01:40Z

tests/utils/vmgroup/vmgrouplifecycle.go

+    return ssh.InvokeCommand(ip, admincli.VmdkopsAdmin+" vmgroup vm rm --name=" + name + " --vm-list=" + vmName )
+}
+
+


nit: please remove extra new lines

shaominchen · 2017-05-23T18:49:14Z

tests/constants/admincli/cmd.go

+	AddVmToVmgroup = vmdkopsAdmin + "vmgroup vm add "
+
+	// remove a vm from vmgroup
+	RemoveVmFrmVmgroup = vmdkopsAdmin + "vmgroup vm rm "


Nit: let's avoid uncommon abbreviations: "Frm" => "From"

shaominchen · 2017-05-23T18:52:14Z

tests/e2e/defaultvmgroup_test.go

+	c.Assert(err, IsNil, Commentf(misc.FormatOutput(out)))
+	c.Assert(strings.TrimRight(string(out), "\n"), Equals, ErrorMsg, Commentf("Unexpected Behavior: "+
+		"We are able to replace vm from the _DEFAULT tenant which is NOT allowed as per current spec."))
+	log.Printf("----Test Ends----")


Let's keep the log style consistent:

log.Printf("END: defaultvmgroup.TestModifyDefaultTenantVMs")

shaominchen · 2017-05-23T18:57:34Z

tests/utils/admincli/vmgroup/vmgrouplifecycle.go

+// This util holds various helper methods related to vmgroup to be consumed by testcases.
+// vmgroup creation, deletion or adding, removing and replacing vm from vmgroup is supported currently.
+
+package vmgroup


Why do we need a separate package for this util? I think we should keep it in admincli package, so that we can use the functions in this util like this: admincli.CreateVmgroup(), which makes more sense than vmgroup.CreateVmgroup()

shuklanirdesh82 · 2017-05-23T20:20:10Z

tests/constants/admincli/cmd.go

+	CreateVmgroup = vmdkopsAdmin + "vmgroup create "
+
+	// remove vmgroup
+	RemoveVmgroup = vmdkopsAdmin + "vmgroup rm "


can you add remaining two constants as well? for list and update

shuklanirdesh82 · 2017-05-23T20:22:35Z

tests/e2e/defaultvmgroup_test.go

+	c.Assert(strings.TrimRight(string(out), "\n"), Equals, ErrorMsg, Commentf("Unexpected Behavior: "+
+		"We are able to add vm to the _DEFAULT tenant which is NOT allowed as per current spec."))
+
+	out, err = vmgroup.RemoveVmFromVmgroup(s.esxIP, admincli.DefaultVmgroup, s.hostName)


it is better to break this test into 3 test methods ... incase of failure for first wont run rest steps.

shuklanirdesh82 · 2017-05-23T20:25:43Z

tests/constants/admincli/cmd.go

@@ -25,4 +25,28 @@ const (

 	// ListVolumes referring to vmdkops_admin volume ls
 	ListVolumes = vmdkopsAdminVolume + "ls "
+
+	// CreateVmgroup referring to create vmgroup
+	CreateVmgroup = vmdkopsAdmin + "vmgroup create "


can you add remaining two constants as well? for list and update

shuklanirdesh82 · 2017-05-23T20:26:07Z

tests/e2e/defaultvmgroup_test.go

+	c.Assert(strings.TrimRight(string(out), "\n"), Equals, ErrorMsg, Commentf("Unexpected Behavior: "+
+		"We are able to add vm to the _DEFAULT tenant which is NOT allowed as per current spec."))
+
+	out, err = admincli.RemoveVmFromVmgroup(s.esxIP, con.DefaultVmgroup, s.hostName)


it is better to break this test into 3 test methods ... incase of failure for first wont run rest steps.

pshahzeb

Looks good. Just one comment about package alias.

pshahzeb · 2017-05-23T22:41:22Z

tests/e2e/defaultvmgroup_test.go

+// 3. Replace a vm from the _DEFAULT tenant
+func (s *DefaultVmGroupTestSuite) TestModifyDefaultTenantVMs(c *C) {
+	log.Printf("START: defaultvmgroup.TestModifyDefaultTenantVMs")
+	out, err := admincli.AddVmToVmgroup(s.esxIP, con.DefaultVmgroup, s.hostName)


i think the alias con is because of the conflicting package name "admincli". Are we opting for aliases in such cases? //CC @shuklanirdesh82 @shaominchen

These are the two conflicting package names:
github.com/vmware/docker-volume-vsphere/tests/constants/admincli
github.com/vmware/docker-volume-vsphere/tests/utils/admincli

If there are conflicts, we have to use alias in such cases. However, for this minimal project, we are running into package conflicts with our own packages! This is an obvious evidence that we are not managing packages properly. I think we should move all existing constant files to the same package under utils. Let's revisit this later as a refactoring issue.

with this respective, we should rename package by suffix it with "const" ..

e.g. github.com/vmware/docker-volume-vsphere/tests/constants/admincliconst

This is one option, but we might have other better options to avoid so many folders/packages just for constants. Let's think about this and revisit this part if any ideas coming to mind.

I have re-named the package to github.com/vmware/docker-volume-vsphere/tests/constants/admincliconst

Let's hold on this change for now and keep the alias. Later we can have a separate refactoring change to address this package name conflict issue.

shaominchen

LGTM. Please address the remaining nits and check CI failures.

shaominchen · 2017-05-23T23:29:26Z

tests/utils/admincli/vmgroupmgmt.go

@@ -52,3 +52,15 @@ func ReplaceVmFromVmgroup(ip, name, vmName string) ([]byte, error) {
 	log.Printf("Replacing VM [%s] from a vmgroup [%s] on esx [%s] \n", vmName, name, ip)
 	return ssh.InvokeCommand(ip, admincli.ReplaceVmFrmVmgroup+"--name="+name+" --vm-list="+vmName)
 }
+
+// Initialize the (local) Single Node Config DB
+func ConfigInit(ip string) ([]byte, error) {


We should improve this function to support both SingleNode and MultiNode. But I'm fine to take care of this whenever we need it afterwards.

Yes, I thought about this while writing SingleNode util but since we do not need it for this test I didn't add it. I can address this later on.

shuklanirdesh82

It looks good to me .. just a minor comment.

shuklanirdesh82 · 2017-05-24T01:21:08Z

tests/e2e/defaultvmgroup_test.go

+
+// Test step:
+// Add a vm to the _DEFAULT Vmgroup
+func (s *DefaultVmGroupTestSuite) TestAddVmToDefaultTenant(c *C) {


to maintain consistency Vm should be VM e.g. TestAddVMToDefaultTenant .. need to replace it everywhere.

pshahzeb

LGTM. Contingent to CI pass.

shuklanirdesh82

@ashahi1 let's unblock this test automation as the reported issue has root caused.

If CI passes after addressing comment, we should proceed with checkin.

shuklanirdesh82 · 2017-05-25T02:26:02Z

tests/e2e/defaultvmgroup_test.go

+	hostName string
+}
+
+func (s *DefaultVMGroupTestSuite) SetUpTest(c *C) {


while talking with @pshahzeb came to know that we missed this line. This should be test suite level.

shuklanirdesh82 · 2017-05-25T02:26:18Z

tests/e2e/defaultvmgroup_test.go

+}
+
+/*
+func (s *DefaultVMGroupTestSuite) TearDownTest(c *C) {


same as above .. should be test suite level.

Yes...I tested it locally yesterday and it was passing. Let me make a fresh push with these changes and check if CI passes. We can add another test that does config init and config rm multiple times and then check the status of vmdk-opsd.

sounds good. Please make sure to raise a tracking issue to add new steps to cover above steps.

shuklanirdesh82 · 2017-05-25T18:04:08Z

@ashahi1, Please rebase your brach with master and run locally before triggering CI run.

From your PR's current CI run: https://ci.vmware.run/vmware/docker-volume-vsphere/258

=> Running target e2e-dkrVolDriver-test Thu May 25 17:28:11 UTC 2017

# github.com/vmware/docker-volume-vsphere/tests/utils/admincli
../tests/utils/admincli/vmgroupmgmt.go:29: cannot use string as type []byte in return argument
../tests/utils/admincli/vmgroupmgmt.go:35: cannot use string as type []byte in return argument
../tests/utils/admincli/vmgroupmgmt.go:41: cannot use string as type []byte in return argument
../tests/utils/admincli/vmgroupmgmt.go:47: cannot use string as type []byte in return argument
../tests/utils/admincli/vmgroupmgmt.go:53: cannot use string as type []byte in return argument
../tests/utils/admincli/vmgroupmgmt.go:59: cannot use string as type []byte in return argument
../tests/utils/admincli/vmgroupmgmt.go:65: cannot use string as type []byte in return argument
FAIL	github.com/vmware/docker-volume-vsphere/tests/e2e [build failed]
make[1]: *** [e2e-dkrVolDriver-test] Error 2
make: *** [e2e-dkrVolDriver-test] Error 2

P.S.: We should start taking CI failure seriously by avoid such obvious failures.

/CC @tusharnt

govint · 2017-05-26T12:49:27Z

tests/constants/admincli/cmd.go

+	// ListVMgroups referring to vmdkops_admin vmgroups ls
+	ListVMgroups = vmdkopsAdmin + "vmgroup ls "
+
+	// UpdateVMgroup referring to updating a vmgroup


For all the commands that take a "--name" arg - especially for the vmgroup commands please add that (--name) to the constants above. The users of these constants need less string additions in the calling code.

govint · 2017-05-26T13:03:45Z

tests/e2e/defaultvmgroup_test.go

+func (s *DefaultVMGroupTestSuite) SetUpSuite(c *C) {
+	s.hostName = govc.RetrieveVMNameFromIP(os.Getenv("VM2"))
+	s.esxIP = os.Getenv("ESX")
+	out, err := admincli.ConfigInit(os.Getenv("ESX"))


Pls. get all values from the inputparams pkg. Thats the single place where env/govc should be used to get values.

Will be addressed in #1305

shuklanirdesh82 · 2017-05-26T18:53:52Z

@ashahi1 Please squash all commits ... there should be atleast 1 commit.

…rameters (addressing Govindan's comment)

ashahi1 · 2017-06-23T00:57:11Z

fix for case 2 #1261

ashahi1 self-assigned this May 22, 2017

ashahi1 requested review from shuklanirdesh82, shaominchen and pshahzeb May 22, 2017 20:06

vmwclabot added the cla-not-required label May 22, 2017

pshahzeb suggested changes May 22, 2017

View reviewed changes

shaominchen suggested changes May 23, 2017

View reviewed changes

shuklanirdesh82 suggested changes May 23, 2017

View reviewed changes

shaominchen reviewed May 23, 2017

View reviewed changes

shuklanirdesh82 added the kind/test label May 23, 2017

shuklanirdesh82 reviewed May 23, 2017

View reviewed changes

shuklanirdesh82 suggested changes May 23, 2017

View reviewed changes

shuklanirdesh82 reviewed May 23, 2017

View reviewed changes

shuklanirdesh82 suggested changes May 23, 2017

View reviewed changes

pshahzeb reviewed May 23, 2017

View reviewed changes

shaominchen approved these changes May 23, 2017

View reviewed changes

shuklanirdesh82 approved these changes May 24, 2017

View reviewed changes

pshahzeb approved these changes May 24, 2017

View reviewed changes

shuklanirdesh82 suggested changes May 25, 2017

View reviewed changes

ashahi1 force-pushed the verifyAddingVmToDefaultTenant.ashahi1 branch from 419f380 to 9127201 Compare May 25, 2017 18:56

govint reviewed May 26, 2017

View reviewed changes

govint mentioned this pull request May 26, 2017

Add vmgroup tests #1286

Merged

govint reviewed May 26, 2017

View reviewed changes

Test to verify add, remove and replace of a vm from the _DEFAULT tenant

185bab8

ashahi1 force-pushed the verifyAddingVmToDefaultTenant.ashahi1 branch from 910b7ba to 95595e1 Compare May 26, 2017 23:32

declared --name as constant and moved some test constanst to input pa…

697b1d0

…rameters (addressing Govindan's comment)

ashahi1 force-pushed the verifyAddingVmToDefaultTenant.ashahi1 branch from 95595e1 to 697b1d0 Compare May 26, 2017 23:33

shuklanirdesh82 approved these changes May 27, 2017

View reviewed changes

shuklanirdesh82 merged commit e410302 into vmware-archive:master May 27, 2017

ashahi1 deleted the verifyAddingVmToDefaultTenant.ashahi1 branch June 8, 2017 00:11

		@@ -0,0 +1,67 @@
		//
		// http://www.apache.org/licenses/LICENSE-2.0

		// vmgroup creation, deletion is supported as of now.


		package vmgroup



		// CreateVmgroup method is going to create a vmgroup and adds vm to it
		func CreateVmgroup(ip, name string, vmName string) ([]byte, error) {

		return ssh.InvokeCommand(ip, admincli.VmdkopsAdmin+" vmgroup vm rm --name=" + name + " --vm-list=" + vmName )
		}

Test to verify add, remove and replace of a vm from the _DEFAULT tenant #1283

Test to verify add, remove and replace of a vm from the _DEFAULT tenant #1283

Conversation

ashahi1 commented May 22, 2017

pshahzeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaominchen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pshahzeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaominchen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shuklanirdesh82 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pshahzeb left a comment

Choose a reason for hiding this comment

shuklanirdesh82 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shuklanirdesh82 commented May 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaominchen left a comment •

edited

Loading