Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for openmanage host ip #785

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

Pengpengwanga
Copy link
Contributor

Signed-off-by: Pengpeng Wang pengpengw@vmware.com

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #785 (6853628) into master (613a655) will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #785      +/-   ##
============================================
+ Coverage     40.61%   40.65%   +0.03%     
- Complexity     1543     1544       +1     
============================================
  Files           233      233              
  Lines         12856    12859       +3     
  Branches       1712     1713       +1     
============================================
+ Hits           5222     5228       +6     
+ Misses         6968     6962       -6     
- Partials        666      669       +3     
Flag Coverage Δ Complexity Δ
aggregator 28.11% <ø> (ø) 63.00 <ø> (ø)
api 64.35% <33.33%> (+0.12%) 591.00 <0.00> (+1.00)
infoblox 54.04% <ø> (ø) 70.00 <ø> (ø)
labsdb 24.84% <ø> (ø) 30.00 <ø> (ø)
management 5.67% <ø> (ø) 9.00 <ø> (ø)
nlyte 30.88% <ø> (ø) 200.00 <ø> (ø)
openmanage 41.76% <ø> (ø) 151.00 <ø> (ø)
poweriq 42.21% <ø> (ø) 269.00 <ø> (ø)
vc 33.24% <ø> (ø) 145.00 <ø> (ø)
vro 5.46% <ø> (ø) 16.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ware/flowgate/service/ServerValidationService.java 24.67% <33.33%> (+1.70%) 6.00 <0.00> (ø)
...e/flowgate/exception/WormholeRequestException.java 52.94% <0.00%> (+11.76%) 7.00% <0.00%> (+1.00%)

Signed-off-by: Pengpeng Wang <pengpengw@vmware.com>
@yixingjia yixingjia merged commit 5c76f6e into vmware:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input a invalid server Ip but save succed when creating a openmanage integration
2 participants