Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDDCSoftware password is not desensitized #803

Merged

Conversation

YangJiao0817
Copy link
Contributor

Signed-off-by: YangJiao jiaoya@vmware.com

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #803 (b1d8b13) into master (6260f98) will increase coverage by 0.03%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #803      +/-   ##
============================================
+ Coverage     41.60%   41.63%   +0.03%     
- Complexity     1565     1570       +5     
============================================
  Files           233      233              
  Lines         12875    12888      +13     
  Branches       1720     1725       +5     
============================================
+ Hits           5356     5366      +10     
- Misses         6828     6830       +2     
- Partials        691      692       +1     
Flag Coverage Δ Complexity Δ
aggregator 28.11% <25.00%> (ø) 63.00 <0.00> (ø)
api 64.40% <73.07%> (+0.04%) 596.00 <1.00> (+5.00)
infoblox 54.04% <ø> (ø) 70.00 <ø> (ø)
labsdb 24.84% <ø> (ø) 30.00 <ø> (ø)
management 5.67% <ø> (ø) 9.00 <ø> (ø)
nlyte 30.88% <0.00%> (ø) 200.00 <0.00> (ø)
openmanage 42.01% <ø> (ø) 152.00 <ø> (ø)
poweriq 42.21% <ø> (ø) 269.00 <ø> (ø)
vc 41.45% <ø> (ø) 165.00 <ø> (ø)
vro 5.46% <ø> (ø) 16.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...te/aggregator/scheduler/job/AggregatorService.java 27.78% <0.00%> (ø) 27.00 <0.00> (ø)
...ate/aggregator/scheduler/job/VROJobDispatcher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...te/nlyteworker/scheduler/job/NlyteDataService.java 28.29% <0.00%> (ø) 40.00 <0.00> (ø)
...re/flowgate/controller/SDDCSoftwareController.java 62.76% <73.07%> (+1.05%) 26.00 <1.00> (+5.00)
...aggregator/scheduler/job/VCenterJobDispatcher.java 41.17% <100.00%> (ø) 4.00 <0.00> (ø)

INSERT INTO flowgate (KEY, VALUE) VALUES ("e1edca8a53794289827896a1aa5aec0f", {"_class":"com.vmware.flowgate.common.model.WormholeRole","roleName":"admin","privilegeNames":["getAllMetricDatasByIDAndDuration","readAllFacilityAdapters","createFacilityAdapter","updateFacilityAdapter","readAnFacilityAdapterById","deleteAnFacilityAdapterById","readFacilityAdaptersByPage","batchCreateAssetIpMapping","updateHostNameAndIPMappingByID","searchAssetName","readHostNameAndIPMappingByPage","deleteHostNameAndIPMappingByID","mappingfacility","readServerMappingByID","readPDUMetricsDataByAssetID","readServerMetricsDataByAssetID","readAssetByAssetNameAndAssetNumber","updateExpiredTimeRange","getExpiredTimeRange","cleanRealTimeDataByTimeRange","readAssetByPduIsNotNull","deleteServerMapping","readMappingsByVROID","readMappingsByVCID","readAssetBySource","updateFacilitySoftwareConfigStatus","updateSddcSoftwareConfigStatus","readSystemSummary","tempHumidityMapping","readUserByUserName","facilityServerSyncDataByServerId","syncDataByServerId","readVROByUser","readUnMappedServers","readAssetsByVCID","readPrivileges","createAnAsset","createAssets","readAsset","readAssetByAssetName","readAssetBySourceAndType","readAssetByType","readMappedAsset","readAssetByKeywords","readAssetByPduIsNull","updateAsset","deleteAsset","createRealTimeSensorDatas","createRealTimeSensorData","readServerSensorData","createServerMapping","readAssetsByVROID","updateServerMapping","mergeServerMapping","readMappingsByVROIDAndPage","readMappingsByVCIDAndPage","createHostNameAndIPMapping","createFacilitySoftwareConfig","readFacilityByID","readFacilityByType","readInternalFacilityByID","readInternalFacilityByType","readFacilityByPage","deleteFacilitySoftwareConfig","updateFacilitySoftwareConfig","startFullMappingAggregation","generateServerPDUMapping","syncHostnameByIp","readVROJobs","readVCJobs","readJobByType","createSddcSoftwareConfig","deleteSddcSoftwareConfig","updateSddcSoftwareConfig","readSddcSoftwareConfigByID","readSddcSoftwareConfigByVC","readSddcSoftwareConfigByUserAndPage","readVROsSddcSoftwareConfigByUser","readSddcSoftwareConfigByTypeAndUser","createSensorSetting","readSensorSettingByID","readSensorSettingsByPage","updateSensorSetting","deleteSensorSetting","readHostNameAndIPMapping","deleteUser","updateUser","readUserByID","readUserByPage","readUsers","createRole","readRole","readRolesByPage","deleteRole","updateRole","Default_Access_Privilege"]});
INSERT INTO flowgate (KEY, VALUE) VALUES ("e1edca8a53002379827896a1bc2aec9i", {"_class":"com.vmware.flowgate.common.model.WormholeRole","roleName":"api","privilegeNames":["getAllMetricDatasByIDAndDuration","mappingfacility","readServerMappingByID","syncHostnameByIp","readPDUMetricsDataByAssetID","readServerMetricsDataByAssetID","readAssetByAssetNameAndAssetNumber","readAssetByPduIsNotNull","deleteServerMapping","readMappingsByVROID","readMappingsByVCID","readAssetBySource","updateSddcSoftwareConfigStatus","readVROByUser","readAssetsByVCID","readAsset","readAssetByAssetName","readAssetBySourceAndType","readAssetByType","readMappedAsset","readAssetByKeywords","readAssetByPduIsNull","createServerMapping","readAssetsByVROID","updateServerMapping","mergeServerMapping","readMappingsByVROIDAndPage","readMappingsByVCIDAndPage","createSddcSoftwareConfig","deleteSddcSoftwareConfig","updateSddcSoftwareConfig","readSddcSoftwareConfigByID","readSddcSoftwareConfigByVC","readSddcSoftwareConfigByUserAndPage","readVROsSddcSoftwareConfigByUser","readSddcSoftwareConfigByTypeAndUser","readHostNameAndIPMapping","Default_Access_Privilege","readInternalFacilityByID","readInternalFacilityByType"]});
INSERT INTO flowgate (KEY, VALUE) VALUES ("e1edca8a53794289827896a1aa5aec0f", {"_class":"com.vmware.flowgate.common.model.WormholeRole","roleName":"admin","privilegeNames":["getAllMetricDatasByIDAndDuration","readAllFacilityAdapters","createFacilityAdapter","updateFacilityAdapter","readAnFacilityAdapterById","deleteAnFacilityAdapterById","readFacilityAdaptersByPage","batchCreateAssetIpMapping","updateHostNameAndIPMappingByID","searchAssetName","readHostNameAndIPMappingByPage","deleteHostNameAndIPMappingByID","mappingfacility","readServerMappingByID","readPDUMetricsDataByAssetID","readServerMetricsDataByAssetID","readAssetByAssetNameAndAssetNumber","updateExpiredTimeRange","getExpiredTimeRange","cleanRealTimeDataByTimeRange","readAssetByPduIsNotNull","deleteServerMapping","readMappingsByVROID","readMappingsByVCID","readAssetBySource","updateFacilitySoftwareConfigStatus","updateSddcSoftwareConfigStatus","readSystemSummary","tempHumidityMapping","readUserByUserName","facilityServerSyncDataByServerId","syncDataByServerId","readVROByUser","readUnMappedServers","readAssetsByVCID","readPrivileges","createAnAsset","createAssets","readAsset","readAssetByAssetName","readAssetBySourceAndType","readAssetByType","readMappedAsset","readAssetByKeywords","readAssetByPduIsNull","updateAsset","deleteAsset","createRealTimeSensorDatas","createRealTimeSensorData","readServerSensorData","createServerMapping","readAssetsByVROID","updateServerMapping","mergeServerMapping","readMappingsByVROIDAndPage","readMappingsByVCIDAndPage","createHostNameAndIPMapping","createFacilitySoftwareConfig","readFacilityByID","readFacilityByType","readInternalFacilityByID","readInternalFacilityByType","readFacilityByPage","deleteFacilitySoftwareConfig","updateFacilitySoftwareConfig","startFullMappingAggregation","generateServerPDUMapping","syncHostnameByIp","readVROJobs","readVCJobs","readJobByType","createSddcSoftwareConfig","deleteSddcSoftwareConfig","updateSddcSoftwareConfig","readSddcSoftwareConfigByID","readSddcSoftwareConfigByVC","readSddcSoftwareConfigByUserAndPage","readVROsSddcSoftwareConfigByUser","readSddcSoftwareConfigByTypeAndUser","createSensorSetting","readSensorSettingByID","readSensorSettingsByPage","updateSensorSetting","deleteSensorSetting","readHostNameAndIPMapping","deleteUser","updateUser","readUserByID","readUserByPage","readUsers","createRole","readRole","readRolesByPage","deleteRole","updateRole","Default_Access_Privilege","readInternalSddcSoftwareConfigByType"]});
INSERT INTO flowgate (KEY, VALUE) VALUES ("e1edca8a53002379827896a1bc2aec9i", {"_class":"com.vmware.flowgate.common.model.WormholeRole","roleName":"api","privilegeNames":["getAllMetricDatasByIDAndDuration","mappingfacility","readServerMappingByID","syncHostnameByIp","readPDUMetricsDataByAssetID","readServerMetricsDataByAssetID","readAssetByAssetNameAndAssetNumber","readAssetByPduIsNotNull","deleteServerMapping","readMappingsByVROID","readMappingsByVCID","readAssetBySource","updateSddcSoftwareConfigStatus","readVROByUser","readAssetsByVCID","readAsset","readAssetByAssetName","readAssetBySourceAndType","readAssetByType","readMappedAsset","readAssetByKeywords","readAssetByPduIsNull","createServerMapping","readAssetsByVROID","updateServerMapping","mergeServerMapping","readMappingsByVROIDAndPage","readMappingsByVCIDAndPage","createSddcSoftwareConfig","deleteSddcSoftwareConfig","updateSddcSoftwareConfig","readSddcSoftwareConfigByID","readSddcSoftwareConfigByVC","readSddcSoftwareConfigByUserAndPage","readVROsSddcSoftwareConfigByUser","readSddcSoftwareConfigByTypeAndUser","readHostNameAndIPMapping","Default_Access_Privilege","readInternalFacilityByID","readInternalFacilityByType","readInternalSddcSoftwareConfigByType"]});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for api role.

@YangJiao0817 YangJiao0817 force-pushed the it-management-desensitization branch from 02639d1 to 77fa5a6 Compare May 13, 2021 09:48
Signed-off-by: YangJiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 force-pushed the it-management-desensitization branch from 77fa5a6 to b1d8b13 Compare May 13, 2021 10:19
@YangJiao0817 YangJiao0817 merged commit fee407c into vmware:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants