Fix infoblox login validation error. #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default getConnection method will try to ping the baseURL, in Infoblox case, the api gateway will return 404 error if flowgate try to access the base url. So we remove the defaul ping action in the method. Signed-off-by: Yixing Jia<yixingj@vmware.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
============================================
+ Coverage 41.74% 41.90% +0.15%
+ Complexity 1580 1535 -45
============================================
Files 233 233
Lines 12891 12878 -13
Branches 1727 1721 -6
============================================
+ Hits 5381 5396 +15
+ Misses 6823 6802 -21
+ Partials 687 680 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default getConnection method will try to ping the baseURL, in Infoblox case, the api gateway will return 404 error if flowgate try to access the base url. So we remove the defaul ping action in the method.
Signed-off-by: Yixing Jiayixingj@vmware.com