Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site and org associations #669

Merged
merged 48 commits into from
Jun 24, 2024
Merged

Site and org associations #669

merged 48 commits into from
Jun 24, 2024

Conversation

dataclouder
Copy link
Collaborator

@dataclouder dataclouder commented Apr 22, 2024 •
edited
Loading

Add types and methods to run association operations between sites and between orgs:

Components:

  • Site retrieval
  • Associated site retrieval
  • Create site association
  • Remove site association
  • Associated org retrieval
  • Create org association
  • Remove org association
  • Query all orgs
  • Comprehensive test involving two sites
  • Test with org-user

To test, read the note in Test_SiteAssociations, containing the environment variables we need to set to start the test.
(Tested with 10.4.2, 10.5.1, 10.6.0)

Note: this PR includes PR #612

@dataclouder
Add more associations retrieval functions
92a2695 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Update associations types
d7c4d4c 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' of https://github.com/medea61/go-vcloud-director …
87b16ad 
…into org-query

Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'org-query' into site-org-associations
a0340fc 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Update cumulative query for Orgs
320f7e0 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder dataclouder mentioned this pull request Apr 24, 2024
Closed
@dataclouder
Check unhandled errors
1b4f0fd 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add functions to get associations data from site/org
1a2489e 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Rename associations*.go to multi_site*.go
fe29a6d 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add methods to set and remove Org associations
c98c011 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add functions to set/remove site associations
58695f5 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add type Site
5a8f935 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add methods GetSite, CheckSiteAssociation, CheckOrgAssociation
4a56d82 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
c32bbd8 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Decouple function newOrgUserConnection
fb9d9ec 
The task of creating a connection for an existing user is now delegated
to newUserConnection

Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add full multi-site test
53c9cdb 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Update tests
9545ac1 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add method AdminOrg.GetAllOpenApiOrgVdcNetworks
dff9744 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add method client.GetAllOrgs for multi-site retrieval of organizations
59f2809 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Improve multi-site test
86ac52d 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
update test
7e4f9cc 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Remove spurious test
264f4ab 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Fix gosec false positive complaint
3966399 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
b50f4cc 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
ea07087 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
546b408 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Update test
d2a2a92 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
a5679a0 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Update cse_util.go (missed from merge)
4e7793b 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
bd2e5ee 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Improve tests
cca57e6 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Fix function comment
bd51ec4 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Add changelog entry
613e1e7 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder dataclouder changed the title [WIP] Site and org associations Site and org associations Jun 12, 2024
@dataclouder dataclouder marked this pull request as ready for review June 12, 2024 10:59
@dataclouder
Merge branch 'main' into site-org-associations
1650941 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
2818fe1 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
7565683 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
7f67778 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder
Merge branch 'main' into site-org-associations
4bf46ca 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
lvirbalas
lvirbalas approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dataclouder
Merge branch 'main' into site-org-associations
781eb7c 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Didainius
Didainius reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM in general. A few things I noticed in comments. Getting two envs to do the test.

types/v56/multi_site.go Show resolved Hide resolved
types/v56/multi_site.go Outdated Show resolved Hide resolved
govcd/system_test.go Outdated Show resolved Hide resolved
govcd/orgs_test.go Show resolved Hide resolved
govcd/multi_site_test.go Show resolved Hide resolved
govcd/multi_site.go Show resolved Hide resolved
govcd/multi_site.go Show resolved Hide resolved
govcd/multi_site.go Show resolved Hide resolved
@dataclouder
Address review requests
7e1c605 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Didainius
Didainius approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run both tests - successfully on 10.5.1

@dataclouder
Merge branch 'main' into site-org-associations
217a353 
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
adambarreiro
adambarreiro approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dataclouder dataclouder merged commit 6bcb3f4 into vmware:main Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dataclouder @adambarreiro @lvirbalas @Didainius @vmwclabot