Update types.go. Add DetectedGuestOS to QueryResultVMRecordType #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slargo
requested review from
lvirbalas,
Didainius,
adambarreiro and
dataclouder
as code owners
|
@slargo, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
adambarreiro
approved these changes
May 10, 2024
There was a problem hiding this comment.
LGTM, vm tests passed on 10.5.1.1
@slargo Would it be possible to add a changelog entry, in the file .changes/v2.25.0/673-improvements.md
With something like
* Added `DetectedGuestOS` to `QueryResultVMRecordType` [GH-673]
Thanks for contributing!
lvirbalas
approved these changes
May 10, 2024
Didainius
approved these changes
May 10, 2024
|
@slargo, VMware has approved your signed contributor license agreement. |
dataclouder
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: (
#672)Add DetectedGuestOS to the struct
A proper Test for AdminVM doesn't exist, but its application it's tested with this modification and the DetectedGuestOS data can be accessed correctly.