Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseAgencyConfigInfo Interface is missing in upstream govmomi if.go #2545

Closed
yuyin002 opened this issue Aug 11, 2021 · 1 comment · Fixed by #2547
Closed

BaseAgencyConfigInfo Interface is missing in upstream govmomi if.go #2545

yuyin002 opened this issue Aug 11, 2021 · 1 comment · Fixed by #2547

Comments

@yuyin002
Copy link

Base interface, such as BaseAgencyInfo, is missing in the upstream if.go. So we need a patch to force generate the base interface.
On top of that, we want to create a new environment variable to indicate all the types we want to force-generate base interface, to give us flexibility in the future.
@github-actions
Copy link
Contributor

Howdy 🖐   yuyin002 ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

This was referenced Aug 11, 2021
Closed
Merged
yuyin002 pushed a commit to yuyin002/govmomi that referenced this issue Jan 12, 2022
fix: Regenerated interface and type to include BaseAgencyConfigInfo. C…
958ac50 
…loses: vmware#2545.

    1- Introduced a new environment variable as a comma-seperated string to indicate the types, which we will consume to force generate the corresponding base interfaces and types;
    2- Regenerated interfaces and types;
    3- Modified code where necessary to consume the change in interfaces and types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@yuyin002