Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] device.info -json does not comply with camelCase fields. #3318

Closed
webbju opened this issue Dec 22, 2023 · 1 comment · Fixed by #3359
Closed

[BUG] device.info -json does not comply with camelCase fields. #3318

webbju opened this issue Dec 22, 2023 · 1 comment · Fixed by #3359

Comments

@webbju
Copy link

webbju commented Dec 22, 2023

Describe the bug
govc device.info -json does not fully comply with camelCase fields.

Related PRs:
#3007
#3247

To Reproduce
Steps to reproduce the behavior:

  1. govc device.info -vm <virtualmachinename -json "disk-*"
  2. Observe output uses upper-case Name and Type.

Expected behavior

  1. Name and Type should be name and type respectively. This would be consistent with the camel-case of other JSON fields.

Affected version
v0.34.1

Screenshots/Debug Output

{
  "devices": [
    {
      "Name": "disk-31000-0",
      "Type": "VirtualDisk",
      "key": 32000,
      "deviceInfo": {
        "label": "Hard disk 1",
        "summary": "157,286,400 KB"
      },
      ...
Copy link
Contributor

Howdy 🖐   webbju ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

dougm added a commit to dougm/govmomi that referenced this issue Feb 8, 2024
BREAKING: follow up to json tags missed in PR vmware#3007 and PR vmware#3247

Closes vmware#3318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant