how can i use customize configuration when cloneing vm? #616

freebsdly · 2016-10-24T16:43:11Z

hi,
how can i use customize configuration file when cloneing vm? i want to set the hostname and ip use customize configuration file.
use "-customization=" ?

kasper5 · 2016-11-03T13:14:36Z

I'd also like to know how I cloud set the ip address when cloning

warroyo · 2016-11-15T20:57:27Z

it looks like you need to create a customization spec in vcenter and use the name of that created spec for reference. however this does not seem very dynamic, how would you chnage these settings at clone time?

mgherman · 2016-11-20T02:29:15Z

When you specify -customization=xxx govc appears to retrieve the customisation from vcenter and injects it into the cloneSpec that is passed to the cmd.VirtualMachine.Clone

I patched the vm.clone command to allow for providing a fixed IP address, netmask and gateway on the command line which modifies the customisation object after it has been retrieved from vcenter, before cmd.VirtualMachine.Clone is called.

Obviously the image you are cloning has to support using the customisation spec, and to be perfectly honest, the code is pretty ugly, has no tests, and is probably not very go-like, but it does what I needed it to do.

Please let me know if you are interested in it.

warroyo · 2016-12-07T17:21:28Z

@mgherman could you please provide this code?

acbox · 2017-02-13T19:27:35Z

+1 @mgherman please share :)

mgherman · 2017-02-20T22:24:54Z

So, this is the diff. You need to have the named customisation already provisioned within vmware, and then provide any / all of the overrides: custip, custgw and custmask which should then override the values in the customisation.

Im sure there is a better way of doing this, but this was sufficient to get it working as a PoC in our environment.

The cmdline flags i was using was something along the lines of:
-customization="nonprod" -custip "10.10.10.32"

+++ clone.go	2017-02-14 22:51:54.622445394 -0800
@@ -28,6 +28,8 @@
 	"github.com/vmware/govmomi/vim25"
 	"github.com/vmware/govmomi/vim25/mo"
 	"github.com/vmware/govmomi/vim25/types"
+
+	"reflect"
 )
 
 type clone struct {
@@ -48,6 +50,9 @@
 	force         bool
 	template      bool
 	customization string
+	custip        string
+	custmask      string
+	custgw        string
 	waitForIP     bool
 
 	Client         *vim25.Client
@@ -98,6 +103,9 @@
 	f.BoolVar(&cmd.force, "force", false, "Create VM if vmx already exists")
 	f.BoolVar(&cmd.template, "template", false, "Create a Template")
 	f.StringVar(&cmd.customization, "customization", "", "Customization Specification Name")
+	f.StringVar(&cmd.custip, "custip", "", "Customization IPAddress")
+	f.StringVar(&cmd.custgw, "custgw", "", "Customization Gateway")
+	f.StringVar(&cmd.custmask, "custmask", "", "Customization Netmask")
 	f.BoolVar(&cmd.waitForIP, "waitip", false, "Wait for VM to acquire IP address")
 }
 
@@ -400,7 +408,23 @@
 		customSpec := customSpecItem.Spec
 		// set the customization
 		cloneSpec.Customization = &customSpec
+
+		xx := customSpec.NicSettingMap[0].Adapter.Ip
+
+		if len(cmd.custip) > 0 {
+			aa := reflect.ValueOf(xx).Elem()
+			bb := aa.FieldByName("IpAddress")
+			bb.SetString(cmd.custip)
+		}
+
+		if len(cmd.custmask) > 0 {
+			customSpec.NicSettingMap[0].Adapter.SubnetMask = cmd.custmask
+		}
+		if len(cmd.custgw) > 0 {
+			customSpec.NicSettingMap[0].Adapter.Gateway[0] = cmd.custgw
+		}
 	}
+		
 
 	// clone virtualmachine
 	return cmd.VirtualMachine.Clone(ctx, cmd.Folder, cmd.name, *cloneSpec)

murarisumit · 2017-03-22T14:43:11Z

@mgherman how did you make the build after making changes,
I used ./build.sh in govmomi/govc directory, after running it gives me error : version mismatch: git=9.0-dirty vs govc=0.14.0

How can I resolve this ?

@dougm can you please help me in building after making changes ??

dougm · 2017-03-22T15:08:18Z

build.sh is for creating releases. Just use 'go build ./govc'

avnish30jn · 2017-09-11T11:18:18Z

Can we create customSpec using govmomi ?

I tried using the method, CreateCustomizationSpec in below file, but that gives error.

govmomi/object/customization_spec_manager.go

Line 69 in f9184c1

    
           func (cs CustomizationSpecManager) CreateCustomizationSpec(ctx context.Context, item types.CustomizationSpecItem) error {

Error:
Required property identity is missing from data object of type CustomizationSpec

The property identity has some dynamic data. How can we set the dynamic data ?

warroyo · 2017-10-10T14:57:29Z

any chance that @mgherman's code could be added to the cli?

dougm · 2017-10-10T18:40:41Z

Yes, can you open a PR @mgherman ?

I think it'd be fine to name those flags with the cust prefix as they wouldn't conflict with any existing flags.

Can also avoid reflection:

		if len(customSpec.NicSettingMap) > 0 {
			nic := customSpec.NicSettingMap[0].Adapter

			if ip, ok := nic.Ip.(*types.CustomizationFixedIp); ok {
				ip.IpAddress = "..."
			}

			nic.SubnetMask = "..."
			nic.Gateway = []string{"..."}
		}

dougm · 2017-10-16T16:35:04Z

Maybe we should consider a new 'vm.customize' command rather than putting more into the clone command? Looks like it's possible to do so after cloning with the CustomizeVm_Task method.

govc vm.clone -on=false template-vm new-vm
govc vm.customize -vm new-vm -ip x.x.x.x -dns-server x.x.x.x -dns-suffix example.com customization-name
govc vm.power -on new-vm

murarisumit · 2017-11-29T06:22:22Z

It it resolved now ??

freebsdly · 2017-12-11T04:30:41Z

@mgherman did it

Boran · 2018-01-03T11:43:48Z

Why was the issue closed? There is no PR yet from gherman's code, this (useful) feature has not been integrated into the govc cli?

dkirrane · 2018-03-18T20:07:03Z

+1 I'd also like to customise -ip, netmask, gateway, dns, disk, -net etc..

xayangjing · 2018-05-09T10:32:16Z

+1 I'd also like to customise -ip, netmask, gateway, dns, disk, -net etc..

sfozz · 2018-06-28T23:49:16Z

+1 it is a feature that is lacking

vincentmli · 2018-06-29T21:51:42Z

+1 for this feature

@mgherman tried your patch to clone.go and build the govc, running govc got error

$./govc vm.clone -vm testvm -customization="test-spec"  -custip="1.1.1.1" new-testvm
./govc: flag provided but not defined: -custip

Am I missing something

neduma · 2018-10-24T18:14:31Z

+1 for this feature.

## Something like 
 govc vm.network.add -vm test-vm -net ISERV_188 -net.adapter vmxnet3 -ip x.x.x.x -dns-server x.x.x.x -dns-suffix example.com

dumez-k · 2018-11-29T20:08:18Z

+1 for this feature.

pytimer · 2018-11-30T01:38:43Z

+1 for this feature.

I try @mgherman patch to clone.go and build govc success. When i run ./govc vm.clone -customization=govc-cust, vm created but ip address not changed. I don't know where is wrong. Maybe my vsphere customization specification.

Anyone have the same problem?

angystardust · 2018-11-30T08:43:17Z

@pytimer i haven't tested the patch but if you're trying to deploy a Linux guest please be remember that...

Linux based OSes requires Perl package to be installed for OS customizations.

(For reference: https://docs.ansible.com/ansible/latest/modules/vmware_guest_module.html#vmware-guest-module)

pytimer · 2018-12-03T02:53:41Z

@angystardust Thanks for you reply.

I follow your said and install Perl package, customization spec is OK. Thanks. :-)

dumez-k · 2018-12-03T15:02:07Z

@pytimer you were able to successfully user the patch? The ip was set?

After applying the patch I'm seeing a panic: reflect: call of reflect.Value.SetString on zero Value error message when attempting to run.

After some debugging it appears that this is because customSpec.NicSettingMap[0].Adapter.Ip is returning a nil object. I figured that this was due to the patch no longer being compatible with the current version of govc (seeing as how the patch is a year old).

If you were able to successfully use the patch though this gives me hope

pytimer · 2018-12-04T01:26:02Z

@dumez-k I update the latest version of govc clone code, you can see this pr: Add customSpec network configuration for govc vm.clone in my fork repository. it works ok for me.

dnicolaev · 2018-12-07T22:31:22Z

Hello, also a question about cloning VMs.
Is there a way to not show all the progress output lines during clone ?

Sometimes there are just about 10 lines - that is fine.
But sometimes there are tons of such lines.

[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(0%)
[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(0%)
[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(0%)
[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(0%)
[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(0%)
[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(5%)
[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(29%)
[07-12-18 15:04:36] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(29%)
[07-12-18 15:04:37] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(32%)
[07-12-18 15:04:37] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(40%)
[07-12-18 15:04:37] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(40%)
[07-12-18 15:04:37] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(94%)
[07-12-18 15:04:37] Cloning /Static/vm/HEAD-current to NightlyBuild_Fix-2018...(94%)

bpottier · 2019-02-21T15:01:58Z

Has there been any update on this? It would be a huge help to have this feature.

dougm · 2019-02-21T19:36:29Z

There is recent discussion here: #984 (comment)

Still no development yet, but hoping to make it happen for the next release in the next few weeks.

Fixes vmware#616 Fixes vmware#984 Closes vmware#1576

dougm mentioned this issue Mar 21, 2017

Give static ip to vm while cloning the template to vm #688

Closed

freebsdly closed this as completed Nov 28, 2017

freebsdly reopened this Jan 4, 2018

stainboy mentioned this issue Jan 4, 2018

CustomizationSpec management API wanted in govc CLI #984

Closed

dougm pushed a commit to dougm/govmomi that referenced this issue Oct 8, 2019

govc: add vm.customize command

a7deae5

Fixes vmware#616 Fixes vmware#984 Closes vmware#1576

dougm closed this as completed in 3185f7b Oct 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

how can i use customize configuration when cloneing vm? #616

how can i use customize configuration when cloneing vm? #616

freebsdly commented Oct 24, 2016

kasper5 commented Nov 3, 2016

warroyo commented Nov 15, 2016

mgherman commented Nov 20, 2016

warroyo commented Dec 7, 2016

acbox commented Feb 13, 2017

mgherman commented Feb 20, 2017

murarisumit commented Mar 22, 2017

dougm commented Mar 22, 2017

avnish30jn commented Sep 11, 2017 •

edited

warroyo commented Oct 10, 2017 •

edited

dougm commented Oct 10, 2017

dougm commented Oct 16, 2017

murarisumit commented Nov 29, 2017

freebsdly commented Dec 11, 2017

Boran commented Jan 3, 2018 •

edited

dkirrane commented Mar 18, 2018

xayangjing commented May 9, 2018

sfozz commented Jun 28, 2018

vincentmli commented Jun 29, 2018

neduma commented Oct 24, 2018

dumez-k commented Nov 29, 2018

pytimer commented Nov 30, 2018

angystardust commented Nov 30, 2018

pytimer commented Dec 3, 2018

dumez-k commented Dec 3, 2018

pytimer commented Dec 4, 2018

dnicolaev commented Dec 7, 2018

bpottier commented Feb 21, 2019

dougm commented Feb 21, 2019

how can i use customize configuration when cloneing vm? #616

how can i use customize configuration when cloneing vm? #616

Comments

freebsdly commented Oct 24, 2016

kasper5 commented Nov 3, 2016

warroyo commented Nov 15, 2016

mgherman commented Nov 20, 2016

warroyo commented Dec 7, 2016

acbox commented Feb 13, 2017

mgherman commented Feb 20, 2017

murarisumit commented Mar 22, 2017

dougm commented Mar 22, 2017

avnish30jn commented Sep 11, 2017 • edited

warroyo commented Oct 10, 2017 • edited

dougm commented Oct 10, 2017

dougm commented Oct 16, 2017

murarisumit commented Nov 29, 2017

freebsdly commented Dec 11, 2017

Boran commented Jan 3, 2018 • edited

dkirrane commented Mar 18, 2018

xayangjing commented May 9, 2018

sfozz commented Jun 28, 2018

vincentmli commented Jun 29, 2018

neduma commented Oct 24, 2018

dumez-k commented Nov 29, 2018

pytimer commented Nov 30, 2018

angystardust commented Nov 30, 2018

pytimer commented Dec 3, 2018

dumez-k commented Dec 3, 2018

pytimer commented Dec 4, 2018

dnicolaev commented Dec 7, 2018

bpottier commented Feb 21, 2019

dougm commented Feb 21, 2019

avnish30jn commented Sep 11, 2017 •

edited

warroyo commented Oct 10, 2017 •

edited

Boran commented Jan 3, 2018 •

edited