-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Release process rehaul #1375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @frapposelli,
I'd like to suggest changing the default behavior of the root Makefile
. With Go 1.10+ supporting build cache, I think it's better to use go build
whenever possible over go install
. It keeps things from polluting the global GOBIN. So instead of using the Makefile's install
target or having test targets depend on install
targets, I think we should have it all depend on build
targets.
It's also consistent with how typical Makefiles differentiate between building and installing.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frapposelli , this is looking good, definitely want to get this in for the next release.
@@ -27,15 +27,15 @@ bastienbc <bastien.barbe.creuly@gmail.com> | |||
Bob Killen <killen.bob@gmail.com> | |||
Brad Fitzpatrick <bradfitz@golang.org> | |||
Bruce Downs <bruceadowns@gmail.com> | |||
Cédric Blomart <cblomart@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, this diff seems to be a difference with sort
between Linux and Mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I noticed as well, will investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I standardized scripts/contributors.sh
on GNU sort, but running it on Mac does not change the outcome... interesting...
Pushed an update with some improvements and added @akutz agree on your suggested changes, will make a separate commits as I need to take a second look at the current Makefile, I focused mostly on |
099cd92
to
826ee58
Compare
Closing this as #2340 and following PRs will fix it using Github Actions. |
This PR intends to rehaul the release process for govc, adding vcsim to the list of artifacts published at every release, and keeping the door open for more (like
toolbox
).Changes:
git-chlog
keeping the same standard structure as before. The old changelogs are preserved and point to the new one.build.sh
andrelease.sh
are removed, replaced bygoreleaser
andgit-chlog
.RELEASE.md
was added, to explain and document the steps required to cut a govmomi release.vcsim
was added as published artifact (binary, brew and docker image)vcsim
andgovc
are compiled forarm
andarm64
platforms./cc @dougm @akutz @lamw