Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Release process rehaul #1375

Closed
wants to merge 2 commits into from

Conversation

frapposelli
Copy link
Member

DO NOT MERGE this PR, upstream work in goreleaser is not complete yet.

This PR intends to rehaul the release process for govc, adding vcsim to the list of artifacts published at every release, and keeping the door open for more (like toolbox).

Changes:

  • Move to a single, autogenerated, changelog. the changelog creation is automated with git-chlog keeping the same standard structure as before. The old changelogs are preserved and point to the new one.
  • build.sh and release.sh are removed, replaced by goreleaser and git-chlog.
  • RELEASE.md was added, to explain and document the steps required to cut a govmomi release.
  • vcsim was added as published artifact (binary, brew and docker image)
  • Both vcsim and govc are compiled for arm and arm64 platforms.

/cc @dougm @akutz @lamw

Copy link
Member

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frapposelli,

I'd like to suggest changing the default behavior of the root Makefile. With Go 1.10+ supporting build cache, I think it's better to use go build whenever possible over go install. It keeps things from polluting the global GOBIN. So instead of using the Makefile's install target or having test targets depend on install targets, I think we should have it all depend on build targets.

It's also consistent with how typical Makefiles differentiate between building and installing.

Thoughts?

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frapposelli , this is looking good, definitely want to get this in for the next release.

vcsim/main.go Outdated Show resolved Hide resolved
@@ -27,15 +27,15 @@ bastienbc <bastien.barbe.creuly@gmail.com>
Bob Killen <killen.bob@gmail.com>
Brad Fitzpatrick <bradfitz@golang.org>
Bruce Downs <bruceadowns@gmail.com>
Cédric Blomart <cblomart@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, this diff seems to be a difference with sort between Linux and Mac.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I noticed as well, will investigate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I standardized scripts/contributors.sh on GNU sort, but running it on Mac does not change the outcome... interesting...

@dougm dougm mentioned this pull request Feb 11, 2019
@frapposelli
Copy link
Member Author

Pushed an update with some improvements and added toolbox to the list of binaries built.

@akutz agree on your suggested changes, will make a separate commits as I need to take a second look at the current Makefile, I focused mostly on goreleaser as it is compiling the binaries independently, without calling the Makefile.

@dougm dougm modified the milestones: 0.23, 0.24 Jun 11, 2020
@dougm dougm modified the milestones: 0.24, 0.25 Dec 18, 2020
@embano1
Copy link
Contributor

embano1 commented Apr 3, 2021

Closing this as #2340 and following PRs will fix it using Github Actions.

@embano1 embano1 closed this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants