Rightly take the host parameter into account while cloning a VM on a cluster #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpillon, VMware has approved your signed contributor license agreement. |
dougm
reviewed
Jun 19, 2021
simulator/virtual_machine.go
Outdated
| @@ -1701,8 +1701,16 @@ func (vm *VirtualMachine) CloneVMTask(ctx *Context, req *types.CloneVM_Task) soa | |||
| pool = vm.ResourcePool | |||
| } | |||
| } | |||
|
|
|||
| DestHost := vm.Runtime.Host | |||
There was a problem hiding this comment.
Non-exported variable names should start with lowercase, can you rename to destHost ?
simulator/virtual_machine.go
Outdated
| DestHost := vm.Runtime.Host | ||
|
|
||
| if req.Spec.Location.Host != nil { | ||
| hostRef := req.Spec.Location.Host.Reference() |
There was a problem hiding this comment.
req.Spec.Location.Host is already a pointer, so there's no need for hostRef here, can do the following instead:
if req.Spec.Location.Host != nil {
destHost = req.Spec.Location.Host
}There was a problem hiding this comment.
Sorry for that, I'm not extremely familiar with Go.
I amended my commit for that (since I also needed to change the commit message)
|
@jpillon one other request, can you prefix the commit message with |
dougm
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just set the Dest Host properly in the clone task
Closes: #2495
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Checklist:
this project