vcsim: propagate CustomizeVM MacAddress to Virtual NIC

[dougm]

Description

The object.VirtualMachine.WaitForNetIP method depends on both the Virtual NIC's MacAddress and
the MacAddress reported by vmware-tools (guest.net[].macaddress property).

With this we can enable WaitForNetIP testing (govc vm.ip) against vcsim.

Related: #2510

Type of change

Please mark options that are relevant:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to
  not work as expected)
• This change requires a documentation update

How Has This Been Tested?

vm.ip bats test enabled against vcsim

Checklist:

• My code follows the CONTRIBUTION guidelines of
  this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

[embano1]

cards slice would always match the number of NIC mappings, i.e. nil pointer exception or cards to settings mismatch would never occur correct?

[dougm]

Right, we validate the length as part of CustomizeVM here:

govmomi/simulator/virtual_machine.go

Lines 1956 to 1961 in 570383b

	if len(vm.Guest.Net) != len(req.Spec.NicSettingMap) {
	return nil, &types.NicSettingMismatch{
	NumberOfNicsInSpec: int32(len(req.Spec.NicSettingMap)),
	NumberOfNicsInVM: int32(len(vm.Guest.Net)),
	}
	}

[embano1]

Sorry for my delayed response Doug. Approving the PR just one minor question to clarify nil semantics.