Fix: use correct controlflag for vslm SetControlFlags API test #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chethanv28
previously approved these changes
Jun 1, 2022
|
nit: title should start with |
divyenpatel
changed the title
divyenpatel
force-pushed
the
fix-SetControlFlags-test
branch
from
7e14a49
to
a982c03
Compare
divyenpatel
changed the title
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FCD_KEEP_AFTER_DELETE_VMis not correct control flag.correcting test to use correct control flag VslmVStorageObjectControlFlagKeepAfterDeleteVm with value
keepAfterDeleteVmType of change
Please mark options that are relevant:
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Validated control flag in this PR - kubernetes-sigs/vsphere-csi-driver#1762
cc: @chethanv28 @bandyopadhyays-vmware