Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

govc: snapshot.tree json output to stdout #3393

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jlehtnie
Copy link

@jlehtnie jlehtnie commented Mar 21, 2024

golang builtin println is meant for debugging only and prints always to stderr

Description

Print json to stdout instead of stderr.

Closes: #3392

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Run command:
govc snapshot.tree -json -vm $vm 2> /dev/null

Obverve json appearing in the terminal.

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

golang builtin println is meant for debugging only and prints
always to stderr
@vmwclabot
Copy link
Member

@jlehtnie, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@jlehtnie, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlehtnie

@dougm dougm merged commit b310f54 into vmware:main Mar 21, 2024
11 of 12 checks passed
@vmwclabot
Copy link
Member

@jlehtnie, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] govc snapshot.tree -json outputs to stderr
4 participants