Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vcsim: re-parent children in ResourcePool.Destroy #3399

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: vcsim: re-parent children in ResourcePool.Destroy #3399

merged 1 commit into from
Apr 4, 2024

Conversation

dougm
Copy link
Member

@dougm dougm commented Apr 2, 2024

Fixes #3396

@dougm dougm mentioned this pull request Apr 2, 2024
Closed
@dougm dougm changed the title fix: vcsim: re-parent children ResourcePool.Destroy fix: vcsim: re-parent children in ResourcePool.Destroy Apr 2, 2024
chrischdi
chrischdi approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dougm this looks good :-)

@fabriziopandini
Copy link
Member

Thanks @dougm!

@dougm dougm merged commit 007b3cd into vmware:main Apr 4, 2024
11 checks passed
@dougm dougm deleted the issue-3396 branch April 4, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] vcsim does not answer govc find after deleting a resource pool which had a child resource pool
4 participants
@dougm @fabriziopandini @chrischdi @vmwclabot