Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfc: Record the SSL thumbprint for the host the (device) URL refers to #3461

Merged

Conversation

HakanSunay
Copy link
Member

Description

With this change we are recording the SSL thumbprint for the host the device URL refers to. This is done so that clients of the nfc wrapper can perform their own SSL verification using the recorded thumbprint if necessary. The thumbprint is stored in the FileItem struct, but the New constructor is not modified so as not to introduce any breaking changes.

Please note that the thumbprint is recorded only for the import case (when deploying an OVF in my case) since that is the only necessary path for our internal usage.

Closes: NA

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

I have performed isolated testing against both a vCenter and a ESXi host. I have observed that the thumbprint is recorded and accessible through the FileItem struct as expected.

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

With this change we are recording the SSL thumbprint for the host the device
URL refers to. This is done so that clients of the nfc wrapper can perform
their own SSL verification using the recorded thumbprint if necessary. The
thumbprint is stored in the FileItem struct, but the New constructor is not
modified so as not to introduce any breaking changes.

Please note that the thumbprint is recorded only for the import case, since
that is the only necessary path for our internal usages.
Copy link
Contributor

@dekp dekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. May populate the thumbprint for the export/download use case later.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HakanSunay HakanSunay merged commit 694a390 into vmware:main Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants