Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsim: add library item storage API support #3462

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

dougm
Copy link
Member

@dougm dougm commented Jun 3, 2024

govc: support Content Library iso files for cdrom backing

The 'device.cdrom.insert' and 'vm.create -iso' commands can now a URL with 'library' scheme to back a cdrom device from a Content Library.

api: refactor 'library.info -L' functionality into library PathFinder helper.

Fixes #3213

@dougm dougm requested a review from dilyar85 June 3, 2024 22:42
@dougm dougm force-pushed the library-path-finder branch 2 times, most recently from 57a8274 to 36bb91e Compare June 3, 2024 23:29
dilyar85
dilyar85 previously approved these changes Jun 4, 2024
Copy link
Member

@dilyar85 dilyar85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

govc/library/info.go Outdated Show resolved Hide resolved
vapi/library/library_item_storage.go Show resolved Hide resolved
govc: support Content Library iso files for cdrom backing

The 'device.cdrom.insert' and 'vm.create -iso' commands can now a URL
with 'library' scheme to back a cdrom device from a Content Library.

api: refactor 'library.info -L' functionality into library PathFinder helper.

Fixes vmware#3213
@dougm dougm merged commit 3e3e439 into vmware:main Jun 4, 2024
10 checks passed
@dougm dougm deleted the library-path-finder branch June 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the usage of .iso files from a Content Library with device.cdrom.insert
3 participants