fix(config-reloader): add timeout seconds on startup #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Cryptophobia
force-pushed
the
fix-golang-fluentd-race-condition-on-init
branch
from
4203dcb
to
70f39eb
Compare
slimm609
approved these changes
Mar 31, 2021
Cryptophobia
force-pushed
the
fix-golang-fluentd-race-condition-on-init
branch
2 times, most recently
from
c805f71
to
d4377ef
Compare
- fix race condition when config-reloader start or restarts - add a timeout default to 30 seconds, that is between 0 - 60 seconds based on cfg.ExecTimeoutSeconds Signed-off-by: Anton Ouzounov <aouzounov@vmware.com>
Cryptophobia
force-pushed
the
fix-golang-fluentd-race-condition-on-init
branch
from
d4377ef
to
e8984fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton Ouzounov aouzounov@vmware.com