-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fluentd log level configurable #196
Make fluentd log level configurable #196
Conversation
@kkapoor1987, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
e68c7fe
to
71210fd
Compare
Signed-off-by: Karan Kapoor karan.kapoor@pega.com Signed-off-by: Karan Kapoor <karan.kapoor@pega.com>
71210fd
to
f97899d
Compare
@Cryptophobia can you review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, looks good. Only a minor mistake in the camel case and we need to add the same env var in the values.yaml file.
@kkapoor1987 , can you also add it to the env vars in the docs here: https://github.com/vmware/kube-fluentd-operator#synopsis with a small description. Also, make sure to say |
@kkapoor1987, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
58a9fc1
to
4f7721e
Compare
@kkapoor1987, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Updated Readme with correct description |
4f7721e
to
17a0c47
Compare
Signed-off-by: Karan Kapoor <karan.kapoor@pega.com>
17a0c47
to
03a148e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thank you for the contribution @kkapoor1987 ! Another release will be coming soon. |
Solves #181
info
is usedSigned-off-by: Karan Kapoor karan.kapoor@pega.com