Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): fix status annot on unused ns #227

Merged
merged 1 commit into from Jun 28, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion config-reloader/datasource/kube_informer.go
Expand Up @@ -71,12 +71,18 @@ func (d *kubeInformerConnection) GetNamespaces() ([]*NamespaceConfig, error) {
}
minis := convertPodToMinis(podList)

// If the AnnotStatus is not present on ns then set IsKnownFromBefore to false
annotStatusExists := false
if _, ok := nsobj.Annotations[d.cfg.AnnotStatus]; ok {
annotStatusExists = true
}

// Create a new NamespaceConfig from the data we've processed up to now
nsconfigs = append(nsconfigs, &NamespaceConfig{
Name: ns,
FluentdConfig: configdata,
PreviousConfigHash: d.hashes[ns],
IsKnownFromBefore: true,
IsKnownFromBefore: annotStatusExists,
Labels: nsobj.Labels,
MiniContainers: minis,
})
Expand Down