Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discovery of fluentdconfig if migration mode is enabled #360

Conversation

jonasrutishauser
Copy link
Contributor

There is a small bug in #310 which gives always the error "Failed to initialize the fluentdconfig crd client, d.fclient = nil".

@vmwclabot
Copy link
Member

@jonasrutishauser, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@javiercri javiercri force-pushed the bugfix/migration-mode-with-cr-namespaces branch from 4065d70 to 71363de Compare January 19, 2023 12:00
@javiercri javiercri self-requested a review January 19, 2023 12:01
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@css.ch>
@slimm609 slimm609 force-pushed the bugfix/migration-mode-with-cr-namespaces branch from 71363de to 6011334 Compare March 16, 2023 11:20
@javiercri javiercri requested review from javiercri and removed request for viveksyngh March 31, 2023 13:15
Copy link
Contributor

@javiercri javiercri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javiercri javiercri merged commit 860cd7c into vmware:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants