Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve dockerfile #386

Merged
merged 2 commits into from
Jun 12, 2023
Merged

feat: improve dockerfile #386

merged 2 commits into from
Jun 12, 2023

Conversation

javiercri
Copy link
Contributor

  • Improve Dockerfile and use best practice

Signed-off-by: jcriadomarco <jcriadomarco@vmware.com>
@javiercri javiercri requested a review from slimm609 June 9, 2023 14:44
@javiercri javiercri force-pushed the improve_dockerfile branch 4 times, most recently from 1a4cb8e to c9bbae8 Compare June 9, 2023 17:52
- Remove build docker file because it was just installing ruby.
- Merge all in one dockerfile

Signed-off-by: jcriadomarco <jcriadomarco@vmware.com>
Copy link
Member

@vsamidurai vsamidurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsamidurai vsamidurai merged commit 3e30d83 into main Jun 12, 2023
1 check passed
@vsamidurai vsamidurai deleted the improve_dockerfile branch June 12, 2023 09:00
lynn-e pushed a commit to lynn-e/kube-fluentd-operator that referenced this pull request Jun 27, 2023
Signed-off-by: jcriadomarco <jcriadomarco@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants