Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add follow_inode to wildcard #400

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: add follow_inode to wildcard #400

merged 1 commit into from
Jun 27, 2023

Conversation

slimm609
Copy link
Contributor

  • add follow_inode to wildcard as recommended by the docs
Avoid to read rotated files duplicately. You should set true when you use * or strftime format in path.

luisdavim
luisdavim approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slimm609 @javiercri
fix: add follow_inode to wildcard
c88d2ce 
- add follow_inode to wildcard as recommended by the docs

Signed-off-by: Brian Davis <dbrian@vmware.com>
@javiercri javiercri merged commit f6622f2 into main Jun 27, 2023
1 check passed
@javiercri javiercri deleted the follow_inodes_wildcard branch June 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisdavim luisdavim luisdavim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slimm609 @luisdavim @javiercri