Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arm64 image is actually x86 #423

Merged
merged 2 commits into from Oct 25, 2023
Merged

Conversation

nhamlh
Copy link
Contributor

@nhamlh nhamlh commented Oct 10, 2023

BUILDPLATFORM is host platform architecture, in this case, Github Action runner, not the architecture of produced image artifact.

From the screenshot bellow we can see that linux/arm64 image sourced photon x86:
image

@vmwclabot
Copy link
Member

@nhamlh, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@nhamlh, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Nham Le <lehoainham@gmail.com>
@vmwclabot
Copy link
Member

@nhamlh, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@slimm609
Copy link
Contributor

DCO was removed due to github rebase. bypassing since it was signed above

@slimm609 slimm609 merged commit fcf5975 into vmware:main Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants