This repository has been archived by the owner. It is now read-only.

Add a toleration to avoid removing the taint on the master nodes #478

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
2 participants
@sguyennet
Copy link

sguyennet commented Apr 20, 2018

What this PR does / why we need it:

Add a toleration to the daemonset to allow scheduling of the pods without removing the taint on the master nodes.

With this toleration, you don't need to do "kubectl taint nodes --all node-role.kubernetes.io/master-" as described in the README:

https://github.com/vmware/kubernetes/blob/enable-vcp-uxi/README.md

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE
@divyenpatel

This comment has been minimized.

Copy link
Member

divyenpatel commented May 2, 2018

@sguyennet change looks good to me.
I will update documentation.

@divyenpatel divyenpatel self-requested a review May 2, 2018

@divyenpatel

This comment has been minimized.

Copy link
Member

divyenpatel commented May 2, 2018

/lgtm

@divyenpatel divyenpatel merged commit 064048b into vmware:enable-vcp-uxi May 2, 2018

@divyenpatel divyenpatel referenced this pull request May 2, 2018

Merged

Update README.md #482

@sguyennet

This comment has been minimized.

Copy link
Author

sguyennet commented May 14, 2018

Hi,

I just noticed that you updated the documentation, but you didn't push a new image on Docker hub:

https://hub.docker.com/r/cnastorage/enablevcp/tags/

The modification I did is embedded in the Docker images, therefore you should build a new one and push it to Docker hub.

@divyenpatel

This comment has been minimized.

Copy link
Member

divyenpatel commented May 14, 2018

@sguyennet I will build and upload new image today.

divyenpatel added a commit that referenced this pull request May 15, 2018

Update enable-vsphere-cloud-provider.yaml
Updating vcp-manager-container image to `cnastorage/enablevcp:latest`.
This image contains changed made by @sguyennet  on the PR: #478
@divyenpatel

This comment has been minimized.

Copy link
Member

divyenpatel commented May 15, 2018

@sguyennet I have pushed new image : cnastorage/enablevcp:v2 containing the changes made in this PR.

Also tagged cnastorage/enablevcp:v2 as cnastorage/enablevcp:latest.

Updated https://github.com/vmware/kubernetes/blob/enable-vcp-uxi/enable-vsphere-cloud-provider.yaml to use latest version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.