This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
Add a toleration to avoid removing the taint on the master nodes #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sguyennet change looks good to me. |
|
/lgtm |
divyenpatel
approved these changes
May 2, 2018
Merged
|
Hi, I just noticed that you updated the documentation, but you didn't push a new image on Docker hub: https://hub.docker.com/r/cnastorage/enablevcp/tags/ The modification I did is embedded in the Docker images, therefore you should build a new one and push it to Docker hub. |
|
@sguyennet I will build and upload new image today. |
divyenpatel
added a commit
that referenced
this pull request
May 15, 2018
Updating vcp-manager-container image to `cnastorage/enablevcp:latest`. This image contains changed made by @sguyennet on the PR: #478
|
@sguyennet I have pushed new image : Also tagged cnastorage/enablevcp:v2 as cnastorage/enablevcp:latest. Updated https://github.com/vmware/kubernetes/blob/enable-vcp-uxi/enable-vsphere-cloud-provider.yaml to use latest version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a toleration to the daemonset to allow scheduling of the pods without removing the taint on the master nodes.
With this toleration, you don't need to do "kubectl taint nodes --all node-role.kubernetes.io/master-" as described in the README:
https://github.com/vmware/kubernetes/blob/enable-vcp-uxi/README.md
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: