Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing/copyright issues: open-vm-tools/lib/string/convertutf.c #148

Closed
bzed opened this issue Mar 1, 2017 · 1 comment
Closed

Licensing/copyright issues: open-vm-tools/lib/string/convertutf.c #148

bzed opened this issue Mar 1, 2017 · 1 comment
Assignees
Labels

Comments

@bzed
Copy link

bzed commented Mar 1, 2017

According to the Debian Free Software Guidelines, the file is not redistributable. Please see the bug against ghostscript for details: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823100
As it seems the code was even removed by the unicode consortium as being buggy and broken.
http://unicode.org/forum/viewtopic.php?f=9&t=90

Please migrate to libicu or something similar.

@oliverkurth oliverkurth self-assigned this Mar 10, 2017
oliverkurth added a commit that referenced this issue Sep 15, 2017
The license for convertutf.c and convertutf.h does not
explicitly permit, or prohibit, modification of the files,
and restricts use to "products supporting the Unicode
Standard". This is a problem for distribution with Debian,
which complies to strict guidelines. See details at
#148
and
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823100

The code is not essential for open-vm-tools. It's needed by
code in bsd_printf.c and related code, which in turn is
needed by msgfmt.c and msgList.c. The latter code is not needed
for open-vm-tools, and can therefore be eliminated from
the open-vm-tools package.

When HAS_BSD_PRINTF isn't set, Str_Snprintf() and
Str_Vsnprintf will fall back to vsnprintf(), and
Str_Asprintf()/Str_Vasprintf() will fall back to
vasprintf(). Under Linux and FreeBSD these functions are
properly implemented, and support %ls and %S.
@oliverkurth
Copy link
Contributor

Fixed with commit 42ac2a1 in the devel branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants