ova-compose: support sha1 checksum type #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bo-gan-broadcom, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
oliverkurth
reviewed
Apr 28, 2024
There was a problem hiding this comment.
Thanks for this.
Please also add it for the tests here: https://github.com/vmware/open-vmdk/blob/master/pytest/test_manifest.py#L64 and here: https://github.com/vmware/open-vmdk/blob/master/pytest/test_manifest.py#L85
ova-compose/ova-compose.py
Outdated
| @@ -1191,7 +1191,7 @@ def usage(): | |||
| print(" -o, --output-file <file> output file or directory name") | |||
| print(" -f, --format ova|ovf|dir output format") | |||
| print(" -m, --manifest create manifest file along with ovf (default true for output formats ova and dir)") | |||
| print(" --checksum-type sha256|sha512 set the checksum type for the manifest. Must be sha256 or sha512.") | |||
| print(" --checksum-type sha1|sha256|sha512 set the checksum type for the manifest. Must be sha1 or sha256 or sha512.") | |||
There was a problem hiding this comment.
Just a nit - change it to "Must be sha1, sha256 or sha512."
Signed-off-by: Bo Gan <bo.gan@broadcom.com>
bo-gan-broadcom
force-pushed
the
topic/bogan/new-sha1-hashsum
branch
from
50fa590
to
a591c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.