Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-ce version 20 support #1231

Closed
blazejpawlak opened this issue Sep 10, 2021 · 21 comments
Closed

Docker-ce version 20 support #1231

blazejpawlak opened this issue Sep 10, 2021 · 21 comments

Comments

@blazejpawlak
Copy link

Are there any plans on moving to Docker-ce version 20?

@dcasota
Copy link
Contributor

dcasota commented Sep 12, 2021

Some days ago there was a post about the docker subscription model change
https://www.docker.com/blog/updating-product-subscriptions/

In addition there is a roadmap web page.
https://github.com/docker/roadmap/projects/1

The distinction of a community edition, open source components and managed aka commercialized business editions isn‘t new.

Not sure why the docker-ce github repo has been marked as deprecated.
https://github.com/docker/docker-ce
However there are some comments about moby/moby and docker/cli ? It simply may have been to early at that time to know what the deprecation means with respect to align support in managed open source and commercialized products first.

@blazejpawlak
Copy link
Author

The announcement is only relevant to Docker Desktop app itself, not the daemon as far as I understand, so this should block Photon from getting an updated v20 RPM package into their repos.

Docker does provide precompiled linux binaries for different architectures at https://docs.docker.com/engine/install/binaries/#install-daemon-and-client-binaries-on-linux

The deprecation of the docker-ce repository also states:

Starting with the Docker 20.10 release, packages for the Docker Engine and Docker CLI are built directly from their respective source repositories instead of from this repository.

Practically this means:

This repository is no longer the “source of truth” for Docker CE builds.
The commit SHA and tag for Docker CLI build will come from the docker/cli repository and the commit SHA and tag for the >Docker Engine will come from the moby/moby repository.
Release branches for the Engine, CLI, and packaging will be maintained on their respective repositories.
Updates will stop being made to this repository and it will be archived in the future.
Changelog is now Release Notes.
The master branch of this repository will be emptied when the repository is archived.

Which means that code will be available in moby and cli repos.

Again I don't see this a blocker.

@blazejpawlak
Copy link
Author

So what do you guys think? Can I help somehow?

@gpiyush-dev
Copy link
Contributor

Sorry for the late response. I am working on upgrading to docker v20 in Photon 4.0. I Will update soon.

@ghost
Copy link

ghost commented Sep 28, 2021

Hi that is great news looking forward to rootless docker. Can the uidmap package be added to the repo, it is not listed and docker rootless mode depends on it. Thank You Sir!

@ghost
Copy link

ghost commented Oct 8, 2021

Hi any update to this please? Time frame to release? Thank you

@gpiyush-dev
Copy link
Contributor

There is some infra issue with our internal ci cd pipeline. As soon as it is fixed should take a week to merge the changes and publish the rpms. Can you point me to uidmap project page so that i can refer the same for adding it?

@ghost
Copy link

ghost commented Oct 11, 2021

Hi thanks for the update.

Some rpm are using shadow-util and deb using uidmap (someone confirm?):

deb linux using uidmap:
https://pkgs.org/search/?q=uidmap

rpm linux using shadow-util:
https://pkgs.org/download/shadow-utils

fedora rpm extra support package for rootless docker:
https://pkgs.org/download/docker-ce-rootless-extras

Also cgroup v2 i think will be required. As v1 is insecure. photonos is using v0.8:
( https://github.com/vmware/photon/blob/master/SPECS/cgroup-utils/cgroup-utils.spec )

docker/docs#11042

Limiting resources with cgroup-related docker run flags such as --cpus, --memory, --pids-limit is supported only when running with cgroup v2 and systemd. See Changing cgroup version to enable cgroup v2 ( https://docs.docker.com/engine/security/rootless/ )

https://fedora.pkgs.org/rawhide/fedora-aarch64/libcgroup-2.0-3.fc35.aarch64.rpm.html

@blazejpawlak
Copy link
Author

Any news on the matter?

@ghost
Copy link

ghost commented Nov 25, 2021

Vmware on low budget? You have a donate page to support? Willing to donate, we are starting to get far behind.

@gpiyush-dev
Copy link
Contributor

Really sorry everyone, I somehow lost track of this as I was working on some other tasks. I will try to get this reviewed and merged by next week for sure.

@dcasota
Copy link
Contributor

dcasota commented Nov 26, 2021

hmm..each package has the same issue. Imho there should be a ~new generic test plan.

  1. backporting to each static Photon OS release (iso, ova, vhd,..)
  2. sideporting to flavor environment linux-esx/linux-aws/linux-rt/linux-secure/linux
  3. packageset-related porting to environment minimal/developer/ostree/real-time/appliance
  4. configuration-related porting to architecture environment x86_86/aarch64 (uefi + mbr)

Doing the math, ten releases each 5 flavors each 5 packagesets each 2 configs, the docker package @gpiyush-dev is caring about, is a good example for the demand of automated testing. And not to forget, the compute burst + storage capacity increment demand with each new release, etc. The time for a simple, automated version bump goes up and down. That's that math array + the daily insecurities patched with the security advisories list as result. This might be rocket science, so what?

@soul-edge haha, willing to donate? can you share eg. a fully productive Tanzu workflow? I can't do it myself either, and I consider myself as a Tanzu beginner struggling with resources of my own.
Cloudnative developers, imho the real experts, know the hands-on with workflows for Photon OS, packages, Python, Go, etc. by heart. That goes not the same for Virtual Experts and consumers. They are happy after a cascade of easy-to-use workflows at scale. Tanzu - Imho a dedicated Photon OS devops chapter in /docs is missing. A docker package workflow is a good entrypoint, indeed. I haven't seen any good reading so far on other Linux distros.

@gpiyush-dev
Copy link
Contributor

Changes are in review. I will update once it is merged.

@gpiyush-dev
Copy link
Contributor

Changes are merged - d740d5f. Will update when RPMS are published.

@ssahani ssahani closed this as completed Dec 10, 2021
@blazejpawlak
Copy link
Author

Will this be part of 4.1 release or something else?

@gpiyush-dev
Copy link
Contributor

you can install this on any photon-4.0 VM once RPMs are published.

@blazejpawlak
Copy link
Author

How do I learn that the RPMs are published?

@gpiyush-dev
Copy link
Contributor

i'll update. if you run tdnf install docker it will install the newer version. If it doesn't install v20 then RPMs are not published yet.

@haata
Copy link
Member

haata commented Dec 13, 2021

Will this be included in photon 3?

@gpiyush-dev
Copy link
Contributor

RPMs are published. Yes, it will be included in photon 3.0. Changes are in review.

@jlanza
Copy link

jlanza commented Jan 12, 2022

Any way to install in rootless mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants