Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress VMware Customer Experience Improvement Program message #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SeanHood
Copy link

Includes updated to pin versions of Powershell, PackageManagement, and PowerShellGet

Fixes: #33

@vmwclabot
Copy link
Member

@SeanHood, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@SeanHood, VMware has approved your signed contributor license agreement.

@@ -14,6 +14,7 @@ RUN echo "/usr/bin/pwsh" >> /etc/shells && \
pwsh -c "\$ProgressPreference = \"SilentlyContinue\"; Install-Module VMware.PowerCLI -RequiredVersion 11.5.0.14912921" && \
pwsh -c "\$ProgressPreference = \"SilentlyContinue\"; Install-Module PowerNSX -RequiredVersion 3.0.1174" && \
pwsh -c "\$ProgressPreference = \"SilentlyContinue\"; Install-Module PowervRA -RequiredVersion 3.6.0" && \
pwsh -c "Set-PowerCLIConfiguration -Scope AllUsers -ParticipateInCEIP \$false -Confirm:\$false" && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will disable CEIP participation for all users using the docker image. We recieve a lot of valuable information for the usage of PowerCLI via the CEIP programme, so we wouldn't like to disable it by default.

Copy link

@agowa agowa Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling it by default is also not an option, because that causes GDPR issues for people using this as a base image...
And asking is also bad because it blocks script execution.

So the only option is to disable it by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most prudent path is indeed to disable CEIP, by default.

pwsh -c "Set-PowerCLIConfiguration -Scope AllUsers -ParticipateInCEIP \$false -Confirm:\$false" && \

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants