fix: fix vsanDataMigrationMode
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
reviewed
Mar 19, 2024
tenthirtyam
reviewed
Mar 19, 2024
tenthirtyam
reviewed
Mar 19, 2024
tenthirtyam
changed the title
vsanDataMigrationMode and 5.1.1 validation
tenthirtyam
force-pushed
the
fix-fix-vsanDataMigrationMode-and-vcf-5.1.1-validation
branch
from
6c99b56
to
959eab0
Compare
- Fixed issue with `vsanDataMigrationMode` not set as optional parameter. - Fixed issue with for loop missing semicolons. - Fixed typo issue with `Request-VCFCertificateCSR` cmdlet name within `Request-SddcCsr` cmdlet. - Validated for VMware Cloud Foundation 5.1.1. Signed-off-by: Kevin Teng <kevin.teng@broadcom.com> fix: update github pull id fix: update github pull id Signed-off-by: Kevin Teng <kevin.teng@broadcom.com>
tenthirtyam
changed the title
vsanDataMigrationMode and 5.1.1 validationvsanDataMigrationMode
tenthirtyam
force-pushed
the
fix-fix-vsanDataMigrationMode-and-vcf-5.1.1-validation
branch
from
959eab0
to
0ffbdbf
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
garlicNova
deleted the
fix-fix-vsanDataMigrationMode-and-vcf-5.1.1-validation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vsanDataMigrationModenot set as optional parameter.Request-VCFCertificateCSRcmdlet name withinRequest-SddcCsrcmdlet.Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
Closes #111
Additional Information