Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add disconnect vCenter Server prior to host restart #36

Merged
merged 4 commits into from
Jun 13, 2023
Merged

fix: add disconnect vCenter Server prior to host restart #36

merged 4 commits into from
Jun 13, 2023

Conversation

garlicNova
Copy link
Contributor

@garlicNova garlicNova commented Jun 12, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Fix add a disconnect from vCenter Server prior to ESXi host reboot.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #22

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

#22 fix add a disconnect from vCenter prior to esxi host reboot.

Signed-off-by: Kevin Teng <kteng@vmware.com>
@garlicNova garlicNova requested a review from a team as a code owner June 12, 2023 18:40
@vmwclabot vmwclabot added the cla-not-required CLA Not Required label Jun 12, 2023
@github-actions github-actions bot added the needs-review Needs Review label Jun 12, 2023
@bhumitra bhumitra changed the title bugfix: issue#22 add disconnect prior to host restart fix: add disconnect vCenter Server prior to host restart Jun 12, 2023
@bhumitra bhumitra added this to the v1.1.0 milestone Jun 12, 2023
Copy link
Contributor

@bhumitra bhumitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garlicNova Please address the comments.
Also update the change log and the build number in the psd file.

@bhumitra bhumitra added bug Bug and removed needs-review Needs Review labels Jun 12, 2023
@tenthirtyam
Copy link
Contributor

Also update the change log and the build number in the psd file.

Examples:

Increment the version to v1.1.0 and the first build. Result: 1.1.0.1000.

    # Version number of this module.
    ModuleVersion = '1.1.0.1000'
# Release History

## v1.1.0 (Not Released)

Bugfix:

- Added a disconnect from vCenter Server prior toan ESXi host reboot`. [GH-36](https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-certificate-management/pull/36)

## [v1.0.0](https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-certificate-management/releases/tag/v1.0.0)

> Release Date: 2023-05-30

Initial availability of the PowerShell module for VMware Cloud Foundation Certificate Management.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

garlicNova and others added 2 commits June 12, 2023 13:48
Co-authored-by: bhumitra nagar <bhumitra@ymail.com>
Signed-off-by: Kevin Teng <kteng@vmware.com>
@garlicNova
Copy link
Contributor Author

all comments addressed

@tenthirtyam
Copy link
Contributor

@garlicNova Please see the version in the comment above. It should 1.1.0 in the CHANGELOG.md and 1.1.0.1000 in the .psd1.

tenthirtyam
tenthirtyam previously approved these changes Jun 13, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

VMware.CloudFoundation.CertificateManagement.psd1 Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam dismissed bhumitra’s stale review June 13, 2023 01:04

Comments addressed.

Addressed review comments.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam merged commit 366b5dc into vmware:main Jun 13, 2023
3 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
@garlicNova garlicNova deleted the bugfix-issue#22-vm-host-reconnect-failure branch August 3, 2023 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug cla-not-required CLA Not Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reconnect to an ESXi host after reboot when vSAN is not used as primary storage
4 participants