-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add disconnect vCenter Server prior to host restart #36
fix: add disconnect vCenter Server prior to host restart #36
Conversation
#22 fix add a disconnect from vCenter prior to esxi host reboot. Signed-off-by: Kevin Teng <kteng@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garlicNova Please address the comments.
Also update the change log and the build number in the psd file.
Examples: Increment the version to # Version number of this module.
ModuleVersion = '1.1.0.1000' # Release History
## v1.1.0 (Not Released)
Bugfix:
- Added a disconnect from vCenter Server prior toan ESXi host reboot`. [GH-36](https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-certificate-management/pull/36)
## [v1.0.0](https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-certificate-management/releases/tag/v1.0.0)
> Release Date: 2023-05-30
Initial availability of the PowerShell module for VMware Cloud Foundation Certificate Management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #36 (comment)
Co-authored-by: bhumitra nagar <bhumitra@ymail.com>
Signed-off-by: Kevin Teng <kteng@vmware.com>
all comments addressed |
@garlicNova Please see the version in the comment above. It should 1.1.0 in the CHANGELOG.md and 1.1.0.1000 in the .psd1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Addressed review comments. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Fix add a disconnect from vCenter Server prior to ESXi host reboot.
Type of Pull Request
Please describe:
Related to Existing Issues
Closes #22
Test and Documentation Coverage
Breaking Changes?