-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance test connection functions #45
feat: enhance test connection functions #45
Conversation
…ion and Test-EsxiConnection Ref: vmware#42 Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Will review and merge once upstream is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes - suggestions added.
Once updated, I will merge and then issue a pull request for the dependency updates, etc.
Apply code review suggestions. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary
Test-VCFConnection
instead ofTest-Connection
where applicable.Test-EsxiConnection
instead ofTest-NetConnection
where applicable.CHANGELOG.md
.These functions internally use Test-EndpointConnection.
Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
Closes #42
Additional Information