Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: module dependencies #48

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: module dependencies #48

merged 1 commit into from
Jul 18, 2023

Conversation

tenthirtyam
Copy link
Contributor

Summary

  • Added the RequiredModules key to the module manifest to specify the minimum dependencies required to install and run the PowerShell module.
  • Bumps PowerValidatedSolutions dependency to v2.5.0 (next release) in the manifest.
  • Bump module version and build to v1.2.0.1001.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Ref: #42

Additional Information

@tenthirtyam tenthirtyam added the chore Chore label Jul 18, 2023
@tenthirtyam tenthirtyam added this to the v1.2.0 milestone Jul 18, 2023
@tenthirtyam tenthirtyam self-assigned this Jul 18, 2023
@vmwclabot vmwclabot added the cla-not-required CLA Not Required label Jul 18, 2023
@github-actions github-actions bot added documentation Documentation needs-review Needs Review and removed chore Chore labels Jul 18, 2023
@tenthirtyam
chore: module dependencies
fe45ccf 
- Added the `RequiredModules` key to the module manifest to specify the minimum dependencies required to install and run the PowerShell module.
- Bumps `PowerValidatedSolutions` dependency to v2.5.0 (next release) in the manifest.
- Bump module version and build to v1.2.0.1001.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam marked this pull request as ready for review July 18, 2023 14:32
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 18, 2023 14:32
GaryJBlake
GaryJBlake approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake removed the needs-review Needs Review label Jul 18, 2023
@GaryJBlake GaryJBlake merged commit fd4413d into main Jul 18, 2023
4 checks passed
@GaryJBlake GaryJBlake deleted the chore/module-dependencies branch July 18, 2023 16:01
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryJBlake GaryJBlake GaryJBlake approved these changes

@bhumitra bhumitra Awaiting requested review from bhumitra

Assignees

@tenthirtyam tenthirtyam

Labels
cla-not-required CLA Not Required documentation Documentation
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tenthirtyam @GaryJBlake @vmwclabot