Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release preparation #58

Merged
merged 9 commits into from
Aug 29, 2023
Merged

chore: release preparation #58

merged 9 commits into from
Aug 29, 2023

Conversation

bhumitra
Copy link
Contributor

@bhumitra bhumitra commented Aug 24, 2023

Summary

Documentation:

  • Updated CHANGELOG.md
  • Bumped up module version number to 1.3.0.1001
  • Added downloads badge in the docs
  • Updated docs with new versions for PowerValidatedSolutions and VMware.PowerCLI

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

tenthirtyam and others added 5 commits August 17, 2023 09:31
Added a note that ESXi certificate management for VMware Cloud Foundation on Dell EMC VxRail is not supported.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Add support for SDDC Manager certificate management operations:

- Set the certificate authority for SDDC Manager (Microsoft only): `Set-SddcCertificateAuthority`.
- Request certificate signing requests from SDDC Manager for a workload domain: `Request-SddcCsr`.
- Request signed certificates from the certificate authority for a workload domain: `Request-SddcCertificate`.
- Install the signed certificates from the certificate authority for a workload domain: `Install-SddcCertificate`.

Signed-off-by: Kevin Teng <kteng@vmware.com>
Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Co-authored-by: Ryan Johnson <johnsonryan@vmware.com>
Updated documentation to reflect support for new capabilities.

Signed-off-by: Kevin Teng <kteng@vmware.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@c85c95e...f43a0e5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bhumitra bhumitra self-assigned this Aug 24, 2023
@vmwclabot vmwclabot added the cla-not-required CLA Not Required label Aug 24, 2023
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
@bhumitra bhumitra added chore Chore documentation Documentation labels Aug 25, 2023
@bhumitra bhumitra marked this pull request as ready for review August 25, 2023 00:03
@bhumitra bhumitra requested a review from a team as a code owner August 25, 2023 00:03
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an update to the manifest to bump PowerValidatedSolutions to 2.6.0.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Badge mentioned in pull request is not present in docs/index.md.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md needs the release date for v1.3.0.

@tenthirtyam tenthirtyam marked this pull request as draft August 25, 2023 00:14
@tenthirtyam tenthirtyam added this to the v1.3.0 milestone Aug 25, 2023
@bhumitra bhumitra marked this pull request as ready for review August 25, 2023 01:00
@bhumitra
Copy link
Contributor Author

Addressed the comments.

@tenthirtyam tenthirtyam self-requested a review August 25, 2023 01:07
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Will merge just prior to release.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhumitra, I noticed that the versions for the dependencies also need to be bumped in the docs/index.md.

@bhumitra
Copy link
Contributor Author

@bhumitra, I noticed that the versions for the dependencies also need to be bumped in the docs/index.md.

Addressing it in a moment.

Signed-off-by: bhumitra nagar <bnagar@vmware.com>
@bhumitra
Copy link
Contributor Author

@bhumitra, I noticed that the versions for the dependencies also need to be bumped in the docs/index.md.

Addressing it in a moment.

Addressed.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Will merge on release day. 🚀

@tenthirtyam tenthirtyam marked this pull request as draft August 25, 2023 19:32
@tenthirtyam tenthirtyam marked this pull request as ready for review August 29, 2023 01:57
@tenthirtyam tenthirtyam merged commit da29230 into main Aug 29, 2023
8 checks passed
tenthirtyam added a commit that referenced this pull request Aug 29, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Chore cla-not-required CLA Not Required documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants