-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update cmdlets and docs #68
Conversation
Ref: vmware#63 Signed-off-by: bhumitra nagar <bnagar@vmware.com>
vmware#61 Signed-off-by: bhumitra nagar <bnagar@vmware.com>
vmware#61 Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Ref: vmware#60 Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
073cb5f
to
cd5f639
Compare
Added review changes. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and will merge shortly. Given that there are breaking changes but this is early in the module's development, I will forego requiring a major version bump.
I made some updates in b51a373.
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary
Enhancement:
Set-SddcCertificateAuthority
to support OpenSSL Certificate Authority configuration.Get-EsxiCertificateThumbprint
andGet-vCenterCertificateThumbprint
to a single functionGet-VCFCertificateThumbprint
.Request-VcfCsr
as a wrapper forRequest-EsxiCsr
andRequest-SddcCsr
Install-VcfCertificate
as a wrapper forInstall-EsxiCertificate
andInstall-SddcCertificate
.Documentation:
Chore:
/docs/documentation
.Type
Breaking Changes?
Test and Documentation
Issue References
Closes #60
Closes #61
Closes #63
Additional Information