Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update cmdlets and docs #68

Merged
merged 8 commits into from
Sep 18, 2023

Conversation

bhumitra
Copy link
Contributor

@bhumitra bhumitra commented Sep 14, 2023

Summary

Enhancement:

  • Breaking Change: Refactored Set-SddcCertificateAuthority to support OpenSSL Certificate Authority configuration.
  • Breaking Change: Refactored Get-EsxiCertificateThumbprint and Get-vCenterCertificateThumbprint to a single function Get-VCFCertificateThumbprint.
  • Added Request-VcfCsras a wrapper for Request-EsxiCsr and Request-SddcCsr
  • Added Install-VcfCertificate as a wrapper for Install-EsxiCertificate and Install-SddcCertificate.

Documentation:

  • Added reference guide for VMware Cloud Foundation Certificate Operations.

Chore:

  • Updated cmdlet content in the /docs/documentation.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #60
Closes #61
Closes #63

Additional Information

@vmwclabot vmwclabot added the cla-not-required CLA Not Required label Sep 14, 2023
@bhumitra bhumitra marked this pull request as ready for review September 15, 2023 00:21
@bhumitra bhumitra requested a review from a team as a code owner September 15, 2023 00:21
@bhumitra bhumitra self-assigned this Sep 15, 2023
@bhumitra bhumitra added this to the v1.4.0 milestone Sep 15, 2023
@tenthirtyam tenthirtyam added the enhancement Enhancement label Sep 18, 2023
Ref: vmware#63

Signed-off-by: bhumitra nagar <bnagar@vmware.com>
vmware#61

Signed-off-by: bhumitra nagar <bnagar@vmware.com>
vmware#61

Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Ref: vmware#60

Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Signed-off-by: bhumitra nagar <bnagar@vmware.com>
Added review changes.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added the documentation Documentation label Sep 18, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and will merge shortly. Given that there are breaking changes but this is early in the module's development, I will forego requiring a major version bump.

I made some updates in b51a373.

@tenthirtyam tenthirtyam changed the title Code updates for Sep release refactor: update cmdlets and docs Sep 18, 2023
@tenthirtyam tenthirtyam added refactor Refactor breaking-change Breaking Change labels Sep 18, 2023
@tenthirtyam tenthirtyam merged commit 7c8f7c2 into vmware:develop Sep 18, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Breaking Change cla-not-required CLA Not Required documentation Documentation enhancement Enhancement refactor Refactor
Projects
None yet
3 participants