Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Get-vSANHealthSummary to report correct status #78

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

bhumitra
Copy link
Contributor

@bhumitra bhumitra commented Oct 4, 2023

Summary

  • Updated Get-vSANHealthSummary to report correct status

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #77

Additional Information

Signed-off-by: bhumitra nagar <bnagar@vmware.com>
@bhumitra bhumitra requested a review from a team as a code owner October 4, 2023 00:05
@vmwclabot vmwclabot added the cla-not-required CLA Not Required label Oct 4, 2023
@bhumitra bhumitra self-assigned this Oct 4, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam added this to the v1.4.0 milestone Oct 4, 2023
@tenthirtyam tenthirtyam changed the title fix: Get-vSANHealthSummary to report correct status fix: update Get-vSANHealthSummary to report correct status Oct 4, 2023
@tenthirtyam tenthirtyam merged commit 854203e into vmware:develop Oct 4, 2023
1 check passed
Copy link

github-actions bot commented Nov 4, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required CLA Not Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-vSANHealthSummary doesn't report any status if status is GREEN
3 participants