Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file path error with linux and macos #97

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: file path error with linux and macos #97

merged 1 commit into from
Dec 5, 2023

Conversation

garlicNova
Copy link
Contributor

@garlicNova garlicNova commented Dec 5, 2023 •
edited by tenthirtyam

Summary

Fixes an issue with the file path on Linux and macOS that is not present on Windows.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #92
Closes #93

Additional Information

@garlicNova garlicNova requested a review from a team as a code owner December 5, 2023 19:26
@vmwclabot vmwclabot added the cla-not-required CLA Not Required label Dec 5, 2023
@tenthirtyam tenthirtyam force-pushed the fix-support-for-MacOS-and-photonOS branch from a221a0e to fb69eb3 Compare December 5, 2023 19:43
@tenthirtyam tenthirtyam changed the title fix:address file path error under linux and macos fix: file path error with linux and macos Dec 5, 2023
@tenthirtyam tenthirtyam added the bug Bug label Dec 5, 2023
@tenthirtyam tenthirtyam force-pushed the fix-support-for-MacOS-and-photonOS branch 2 times, most recently from c12a4e6 to c6ee7a0 Compare December 5, 2023 20:33
@tenthirtyam
fix: file path error with linux and macos
8815270 
Fixes an issue with the file path on Linux and macOS that is not present on Windows.

Ref: vmware#92 vmware#93

Signed-off-by: Kevin Teng <kteng@vmware.com>
@tenthirtyam tenthirtyam force-pushed the fix-support-for-MacOS-and-photonOS branch from c6ee7a0 to 8815270 Compare December 5, 2023 20:37
tenthirtyam
tenthirtyam approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenthirtyam tenthirtyam merged commit bb1e336 into vmware:develop Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
@garlicNova garlicNova deleted the fix-support-for-MacOS-and-photonOS branch January 5, 2024 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@garlicNova garlicNova

Labels
bug Bug cla-not-required CLA Not Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install-VCFCertificate not working on macOS Install-VCFCertificate not working on Photon OS 5
3 participants
@garlicNova @tenthirtyam @vmwclabot