Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for vcf 5.0 #37

Merged
merged 3 commits into from
Jul 13, 2023
Merged

feat: add support for vcf 5.0 #37

merged 3 commits into from
Jul 13, 2023

Conversation

garlicNova
Copy link
Contributor

@garlicNova garlicNova commented Jul 12, 2023

Summary

Sample Scripts:

  • Added support for VMware Cloud Foundation 5.0 and isolated workload domains.
  • Added an internal debug function to each sample script.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Tested on:

  • Windows Server 2019
  • PowerShell Core 7.3.5
  • VMware Cloud Foundation 5.0

Issue References

Additional Information

add support for vcf 5.0
address issue with isolated domain
change acquiring authentication from SSO to include filter for ssoID
add (internal)debug function to both scripts
Signed-off-by: Kevin Teng <kteng@vmware.com>
@garlicNova garlicNova requested a review from a team as a code owner July 12, 2023 21:15
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Jul 12, 2023
@tenthirtyam tenthirtyam added this to the v1.2.0 milestone Jul 13, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam changed the title feat: add support for VCF 5.0 feat: add support for vcf 5.0 Jul 13, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change to ensure that the CHANGELOG.md is updated with the pull request link.

@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jul 13, 2023
@tenthirtyam tenthirtyam marked this pull request as draft July 13, 2023 16:59
add an if else check for VCF version < 4.5
Signed-off-by: Kevin Teng <kteng@vmware.com>
@garlicNova garlicNova marked this pull request as ready for review July 13, 2023 17:21
change SDDCVer to vcfVersion
change get-vcfmanager to Get-VCFManager

Signed-off-by: Kevin Teng <kteng@vmware.com>
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Kevin!

Leo Clap

@tenthirtyam tenthirtyam merged commit a534369 into vmware:main Jul 13, 2023
2 checks passed
@tenthirtyam tenthirtyam added enhancement Enhancement and removed documentation Documentation labels Jul 13, 2023
@tenthirtyam tenthirtyam mentioned this pull request Jul 18, 2023
11 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants