Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secure strings for sensitive parameters #73

Conversation

Ashwini-Ravi
Copy link
Contributor

Summary

add secure strings for sensitive parameters

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #72 

Additional Information

@Ashwini-Ravi Ashwini-Ravi marked this pull request as ready for review November 16, 2023 06:06
@Ashwini-Ravi Ashwini-Ravi requested a review from a team as a code owner November 16, 2023 06:06
@tenthirtyam tenthirtyam added the enhancement Enhancement label Nov 16, 2023
@tenthirtyam tenthirtyam added this to the v1.3.0 milestone Nov 16, 2023
@tenthirtyam tenthirtyam linked an issue Nov 16, 2023 that may be closed by this pull request
4 tasks
feat: add secure strings for sensitive parameters

#ref: 72

Signed-off-by: Ashwini Ravindernath <aravindernat@vmware.com>
@tenthirtyam tenthirtyam force-pushed the feat-add-secure-strings-for-sensitive-parameters branch from 1fadc47 to 96dd719 Compare November 16, 2023 14:13
Amending commit to add version history

Ref: vmware#72

Signed-off-by: Ashwini Ravindernath <aravindernat@vmware.com>
@tenthirtyam tenthirtyam force-pushed the feat-add-secure-strings-for-sensitive-parameters branch from 96dd719 to b3e3824 Compare November 16, 2023 14:16
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

CHANGELOG.md Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam merged commit 095082a into vmware:develop Nov 16, 2023
@tenthirtyam tenthirtyam linked an issue Nov 26, 2023 that may be closed by this pull request
4 tasks
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement
Projects
None yet
2 participants