Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add version health #123

Merged
merged 1 commit into from
Apr 14, 2023
Merged

feat: add version health #123

merged 1 commit into from
Apr 14, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Apr 13, 2023 •
edited
Loading

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Added Publish-VersionHealth to return the version health from the SoS Health Summary JSON data.
  • Updated Invoke-VcfHealthReport to include the version health using the Publish-VersionHealth cmdlet.
  • Fix typos.
  • Bumps the module version to v2.0.0.1008.
  • Updates CHANGELOG.md.

Ref: #41

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Related #41

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

image

image

PS F:\> Publish-VersionHealth -json F:\Reporting\HealthReports\sfo-vcf01-all-health-results.json | more


Component : ESXI
Resource  : sfo01-m01-esx01.sfo.rainpole.io
Version   : 7.0.3-20328353
Alert     : GREEN
Message   : No Version mismatch found for ESXI:sfo01-m01-esx01.sfo.rainpole.io. BOM version 7.0.3-20328353, Component Running installed version 7.0.3-20328353 and VCF Inventory version 7.0.3-20328353 are as expected.

Component : ESXI
Resource  : sfo01-m01-esx02.sfo.rainpole.io
Version   : 7.0.3-20328353
Alert     : GREEN
Message   : No Version mismatch found for ESXI:sfo01-m01-esx02.sfo.rainpole.io. BOM version 7.0.3-20328353, Component Running installed version 7.0.3-20328353 and VCF Inventory version 7.0.3-20328353 are as expected.

Component : ESXI
Resource  : sfo01-m01-esx03.sfo.rainpole.io
Version   : 7.0.3-20328353
Alert     : GREEN
Message   : No Version mismatch found for ESXI:sfo01-m01-esx03.sfo.rainpole.io. BOM version 7.0.3-20328353, Component Running installed version 7.0.3-20328353 and VCF Inventory version 7.0.3-20328353 are as expected.

Component : ESXI
Resource  : sfo01-m01-esx04.sfo.rainpole.io
Version   : 7.0.3-20328353
Alert     : GREEN
Message   : No Version mismatch found for ESXI:sfo01-m01-esx04.sfo.rainpole.io. BOM version 7.0.3-20328353, Component Running installed version 7.0.3-20328353 and VCF Inventory version 7.0.3-20328353 are as expected.

Component : ESXI
Resource  : sfo01-w01-esx01.sfo.rainpole.io
Version   : 7.0.3-20328353
Alert     : GREEN
Message   : No Version mismatch found for ESXI:sfo01-w01-esx01.sfo.rainpole.io. BOM version 7.0.3-20328353, Component Running installed version 7.0.3-20328353 and VCF Inventory version 7.0.3-20328353 are as expected.

Component : ESXI
Resource  : sfo01-w01-esx03.sfo.rainpole.io
Version   : 7.0.3-20328353
Alert     : GREEN
Message   : No Version mismatch found for ESXI:sfo01-w01-esx03.sfo.rainpole.io. BOM version 7.0.3-20328353, Component Running installed version 7.0.3-20328353 and VCF Inventory version 7.0.3-20328353 are as expected.

Component : ESXI
Resource  : sfo01-w01-esx04.sfo.rainpole.io
Version   : 7.0.3-20328353
Alert     : GREEN
Message   : No Version mismatch found for ESXI:sfo01-w01-esx04.sfo.rainpole.io. BOM version 7.0.3-20328353, Component Running installed version 7.0.3-20328353 and VCF Inventory version 7.0.3-20328353 are as expected.

Component : NSX_MANAGER
Resource  : sfo-m01-nsx01.sfo.rainpole.io
Version   : 3.2.1.2.0-20541212
Alert     : GREEN
Message   : No Version mismatch found for NSX_MANAGER:sfo-m01-nsx01.sfo.rainpole.io. BOM version 3.2.1.2.0-20541212, Component Running installed version 3.2.1.2.0-20541212 and VCF Inventory version 3.2.1.2.0-20541212
            are as expected.

Component : NSX_MANAGER
Resource  : sfo-w01-nsx01.sfo.rainpole.io
Version   : 3.2.1.2.0-20541212
Alert     : GREEN
Message   : No Version mismatch found for NSX_MANAGER:sfo-w01-nsx01.sfo.rainpole.io. BOM version 3.2.1.2.0-20541212, Component Running installed version 3.2.1.2.0-20541212 and VCF Inventory version 3.2.1.2.0-20541212
            are as expected.

Component : SDDC
Resource  : sfo-vcf01.sfo.rainpole.io
Version   : 4.5.0.0
Alert     : GREEN
Message   : No Version mismatch found for SDDC:sfo-vcf01.sfo.rainpole.io. BOM version 4.5.0.0, Component Running installed version 4.5.0.0 and VCF Inventory. version 4.5.0.0 are as expected. SDDC Manager Build no. is
            excluded from the check.

Component : VCENTER
Resource  : sfo-m01-vc01.sfo.rainpole.io
Version   : 7.0.3.01000-20395099
Alert     : GREEN
Message   : No Version mismatch found for VCENTER:sfo-m01-vc01.sfo.rainpole.io. BOM version 7.0.3.01000-20395099, Component Running installed version 7.0.3.01000-20395099 and VCF Inventory version 7.0.3.01000-20395099
            are as expected.

Component : VCENTER
Resource  : sfo-w01-vc01.sfo.rainpole.io
Version   : 7.0.3.01000-20395099
Alert     : GREEN
Message   : No Version mismatch found for VCENTER:sfo-w01-vc01.sfo.rainpole.io. BOM version 7.0.3.01000-20395099, Component Running installed version 7.0.3.01000-20395099 and VCF Inventory version 7.0.3.01000-20395099
            are as expected.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
feat: add version health
7801bed 
- Added `Publish-VersionHealth` to return the version health from the SoS Health Summary JSON data.
- Updated `Invoke-VcfHealthReport` to include the version health using the `Publish-VersionHealth` cmdlet.
- Fix typos.
- Bumps the module version to v2.0.0.1008.
- Updates `CHANGELOG.md`.

Ref: #41

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added enhancement Enhancement report/health Health Report labels Apr 13, 2023
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Apr 13, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 13, 2023 17:29
@tenthirtyam tenthirtyam self-assigned this Apr 13, 2023
@tenthirtyam tenthirtyam mentioned this pull request Apr 13, 2023
Closed
4 tasks
GaryJBlake
GaryJBlake approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit b106297 into main Apr 14, 2023
@tenthirtyam tenthirtyam deleted the feat/add-version-health branch April 14, 2023 10:11
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryJBlake GaryJBlake GaryJBlake approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
enhancement Enhancement report/health Health Report
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tenthirtyam @GaryJBlake