Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vsan cluster health checks #124

Merged
merged 2 commits into from
Apr 14, 2023
Merged

feat: add vsan cluster health checks #124

merged 2 commits into from
Apr 14, 2023

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Updated Publish-VsanHealth to include the results for capacity utilization and the active resysc of objects.
  • Bumps the module version to v2.0.0.1009.
  • Updates CHANGELOG.md.

Ref: #103

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #103

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

image

PS F:\> Publish-VsanHealth -json F:\Reporting\HealthReports\sfo-vcf01-all-health-results.json

Component Resource     Alert  Message
--------- --------     -----  -------
vCenter   sfo-m01-cl01 -      Stretched cluster is disabled on cluster: sfo-m01-cl01
vCenter   sfo-m01-cl01 GREEN  There are no Active Re-Syncing happening
vCenter   sfo-m01-cl01 -      Compression is enabled on cluster : sfo-m01-cl01
vCenter   sfo-m01-cl01 -      Deduplication is enabled on cluster : sfo-m01-cl01
vCenter   sfo-m01-cl01 -      Encryption is disabled on cluster : sfo-m01-cl01
vCenter   sfo-m01-cl01 RED    Cluster VSAN Health Check is not successful for following groups ['Capacity utilization']. Please refer to Vcenter Skyline Health for more details about the un-successful tests. Overall t...
vCenter   sfo-m01-cl01 GREEN  All hosts are healthy
vCenter   sfo-m01-cl01 YELLOW vSAN Capacity utilization has reached 70%
vCenter   sfo-w01-cl01 -      Deduplication is disabled on cluster : sfo-w01-cl01
vCenter   sfo-w01-cl01 GREEN  There are no Active Re-Syncing happening
vCenter   sfo-w01-cl01 -      Stretched cluster is disabled on cluster: sfo-w01-cl01
vCenter   sfo-w01-cl01 YELLOW Cluster VSAN Health Check is not successful for following groups ['Online health (Disabled)']. Please refer to Vcenter Skyline Health for more details about the un-successful tests. Overa...
vCenter   sfo-w01-cl01 GREEN  All hosts are healthy
vCenter   sfo-w01-cl01 GREEN  vSAN Capacity utilization is well within thresholds
vCenter   sfo-w01-cl01 -      Encryption is disabled on cluster : sfo-w01-cl01
vCenter   sfo-w01-cl01 -      Compression is disabled on cluster : sfo-w01-cl01

PS F:\> Publish-VsanHealth -json F:\Reporting\HealthReports\sfo-vcf01-all-health-results.json -failureOnly

Component Resource     Alert  Message
--------- --------     -----  -------
vCenter   sfo-m01-cl01 YELLOW vSAN Capacity utilization has reached 70%
vCenter   sfo-m01-cl01 RED    Cluster VSAN Health Check is not successful for following groups ['Capacity utilization']. Please refer to Vcenter Skyline Health for more details about the un-successful tests. Overall t...
vCenter   sfo-w01-cl01 YELLOW Cluster VSAN Health Check is not successful for following groups ['Online health (Disabled)']. Please refer to Vcenter Skyline Health for more details about the un-successful tests. Overa...

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
feat: add vsan cluster health checks
7d56665 
- Updated `Publish-VsanHealth` to include the results for capacity utilization and the active resysc of objects.
- Bumps the module version to v2.0.0.1009.
- Updates `CHANGELOG.md`.

Ref: #103

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added the report/health Health Report label Apr 13, 2023
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Apr 13, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 13, 2023 19:15
@tenthirtyam tenthirtyam self-assigned this Apr 13, 2023
@tenthirtyam tenthirtyam added the enhancement Enhancement label Apr 13, 2023
GaryJBlake
GaryJBlake approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vmwclabot vmwclabot added the dco-required DCO Required label Apr 14, 2023
@GaryJBlake GaryJBlake force-pushed the feat/add-vsan-cluster-health-checks branch from 6dbdf79 to 5d027a0 Compare April 14, 2023 10:13
@GaryJBlake GaryJBlake removed the dco-required DCO Required label Apr 14, 2023
GaryJBlake
GaryJBlake approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake self-requested a review April 14, 2023 10:15
GaryJBlake
GaryJBlake previously approved these changes Apr 14, 2023
View reviewed changes
@tenthirtyam tenthirtyam force-pushed the feat/add-vsan-cluster-health-checks branch from 5d027a0 to c30895f Compare April 14, 2023 12:03
@vmwclabot vmwclabot added the dco-required DCO Required label Apr 14, 2023
@vmware vmware deleted a comment from vmwclabot Apr 14, 2023
@vmware vmware deleted a comment from vmwclabot Apr 14, 2023
@tenthirtyam tenthirtyam force-pushed the feat/add-vsan-cluster-health-checks branch from c30895f to 4ff51fd Compare April 14, 2023 12:13
@tenthirtyam tenthirtyam removed the dco-required DCO Required label Apr 14, 2023
@GaryJBlake @tenthirtyam
fix: address merge conflict
a75ad00 
Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Signed-off-by: Gary Blake <gblake@vmware.com>
@tenthirtyam tenthirtyam force-pushed the feat/add-vsan-cluster-health-checks branch from 4ff51fd to a75ad00 Compare April 14, 2023 12:15
@vmwclabot vmwclabot added the dco-required DCO Required label Apr 14, 2023
@vmware vmware deleted a comment from vmwclabot Apr 14, 2023
@tenthirtyam tenthirtyam removed the dco-required DCO Required label Apr 14, 2023
@vmware vmware deleted a comment from vmwclabot Apr 14, 2023
@vmware vmware deleted a comment from vmwclabot Apr 14, 2023
GaryJBlake
GaryJBlake approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit a438588 into main Apr 14, 2023
@tenthirtyam tenthirtyam deleted the feat/add-vsan-cluster-health-checks branch April 14, 2023 12:26
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryJBlake GaryJBlake GaryJBlake approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
enhancement Enhancement report/health Health Report
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Add support for additional vSAN cluster health checks
3 participants
@tenthirtyam @GaryJBlake @vmwclabot