Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ping connectivity #132

Merged
merged 2 commits into from
May 2, 2023
Merged

feat: add ping connectivity #132

merged 2 commits into from
May 2, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented May 2, 2023 •
edited
Loading

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Added Publish-PingConnectivityHealth to return the ping connectivity health from the SoS Health Summary JSON data.
  • Updated Publish-ComponentConnectivityHealth to include the ping connectivity health using the Publish-PingConnectivityHealth cmdlet.
  • Updated CHANGELOG.md.
  • Updated module version from v2.1.0.1003 to v2.1.0.1004.

In order to have a good experience with our community, we recommend that you read the [contributing guidelines]

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #36

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).
PS F:\Reporting\HealthReports> Publish-PingConnectivityHealth -json .\sfo-vcf01-all-health-results.json

Component Resource                        Alert Message
--------- --------                        ----- -------
ESXi      sfo01-m01-esx01.sfo.rainpole.io GREEN Ping successful!
ESXi      sfo01-m01-esx02.sfo.rainpole.io GREEN Ping successful!
ESXi      sfo01-m01-esx03.sfo.rainpole.io GREEN Ping successful!
ESXi      sfo01-m01-esx04.sfo.rainpole.io GREEN Ping successful!
ESXi      sfo01-w01-esx01.sfo.rainpole.io GREEN Ping successful!
ESXi      sfo01-w01-esx02.sfo.rainpole.io GREEN Ping successful!
ESXi      sfo01-w01-esx03.sfo.rainpole.io GREEN Ping successful!
ESXi      sfo01-w01-esx04.sfo.rainpole.io GREEN Ping successful!
NSX       sfo-m01-nsx01.sfo.rainpole.io   GREEN Ping successful!
NSX       sfo-w01-nsx01.sfo.rainpole.io   GREEN Ping successful!
vCenter   sfo-m01-vc01.sfo.rainpole.io    GREEN Ping successful!
vCenter   sfo-w01-vc01.sfo.rainpole.io    GREEN Ping successful!
PS F:\> Publish-ComponentConnectivityHealth -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -json F:\Reporting\HealthReports\sfo-vcf01-all-health-results.json -allDo
<a id="general-connectivity"></a><h3>Connectivity Health Status</h3>
<table class="table">
<colgroup><col/><col/><col/><col/></colgroup>
<tr><th>Component</th><th>Resource</th><th>Alert</th><th>Message</th></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connectivity check successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx01.sfo.rainpole.io</td><td>-</td><td>** SSH status is disabled.</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx02.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connectivity check successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx02.sfo.rainpole.io</td><td>-</td><td>** SSH status is disabled.</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx02.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx03.sfo.rainpole.io</td><td>-</td><td>** SSH status is disabled.</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx03.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx03.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connectivity check successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx04.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connectivity check successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx04.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-m01-esx04.sfo.rainpole.io</td><td>-</td><td>** SSH status is disabled.</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx01.sfo.rainpole.io</td><td>-</td><td>** SSH status is disabled.</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connectivity check successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx03.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx03.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connectivity check successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx03.sfo.rainpole.io</td><td>-</td><td>** SSH status is disabled.</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx04.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connectivity check successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx04.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>ESXi</td><td>sfo01-w01-esx04.sfo.rainpole.io</td><td>-</td><td>** SSH status is disabled.</td></tr>
<tr><td>NSX</td><td>sfo-m01-nsx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>NSX</td><td>sfo-m01-nsx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>NSX</td><td>sfo-m01-nsx01a.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>NSX</td><td>sfo-m01-nsx01b.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>NSX</td><td>sfo-m01-nsx01c.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>NSX</td><td>sfo-w01-nsx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>NSX</td><td>sfo-w01-nsx01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>NSX</td><td>sfo-w01-nsx01a.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>NSX</td><td>sfo-w01-nsx01b.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>NSX</td><td>sfo-w01-nsx01c.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>vCenter</td><td>sfo-m01-vc01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>vCenter</td><td>sfo-m01-vc01.sfo.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vCenter</td><td>sfo-m01-vc01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>vCenter</td><td>sfo-w01-vc01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>vCenter</td><td>sfo-w01-vc01.sfo.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vCenter</td><td>sfo-w01-vc01.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>API Connection check successful!</td></tr>
<tr><td>VRA</td><td>xint-vra01a.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>VRA</td><td>xint-vra01a.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>VRA</td><td>xint-vra01b.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>VRA</td><td>xint-vra01b.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>VRA</td><td>xint-vra01c.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>VRA</td><td>xint-vra01c.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vRLI</td><td>sfo-vrli01a.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>VRLI</td><td>sfo-vrli01a.sfo.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vRLI</td><td>sfo-vrli01b.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>VRLI</td><td>sfo-vrli01b.sfo.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vRLI</td><td>sfo-vrli01c.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>VRLI</td><td>sfo-vrli01c.sfo.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vROps</td><td>sfo-vropsc01a.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>vROps</td><td>sfo-vropsc01a.sfo.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vROps</td><td>sfo-vropsc01b.sfo.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>vROps</td><td>sfo-vropsc01b.sfo.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vROps</td><td>xint-vrops01a.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vROps</td><td>xint-vrops01a.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>vROps</td><td>xint-vrops01b.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>vROps</td><td>xint-vrops01b.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>vROps</td><td>xint-vrops01c.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>vROps</td><td>xint-vrops01c.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>VRSLCM</td><td>xint-vrslcm01.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>VRSLCM</td><td>xint-vrslcm01.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>WSA</td><td>xint-wsa01a.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>WSA</td><td>xint-wsa01a.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>WSA</td><td>xint-wsa01b.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>WSA</td><td>xint-wsa01b.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>
<tr><td>WSA</td><td>xint-wsa01c.rainpole.io</td><td class="alertOK">GREEN</td><td>Ping successful!</td></tr>
<tr><td>WSA</td><td>xint-wsa01c.rainpole.io</td><td>-</td><td>** SSH status is enabled.</td></tr>

image

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the enhancement Enhancement label May 2, 2023
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone May 2, 2023
@tenthirtyam tenthirtyam self-assigned this May 2, 2023
GaryJBlake
GaryJBlake requested changes May 2, 2023
View reviewed changes
VMware.CloudFoundation.Reporting.psd1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
@tenthirtyam
feat: add ping connectivity
343e932 
- Added `Publish-PingConnectivityHealth` to return the ping connectivity health from the SoS Health Summary JSON data.
- Updated `Publish-ComponentConnectivityHealth` to include the ping connectivity health using the `Publish-PingConnectivityHealth` cmdlet.
- Updated `CHANGELOG.md`.
- Updated module version from v2.1.0.1003 to v2.1.0.1004.

Ref: #36

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
GaryJBlake
GaryJBlake approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vmwclabot vmwclabot added the dco-required DCO Required label May 2, 2023
@tenthirtyam tenthirtyam marked this pull request as ready for review May 2, 2023 13:41
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 2, 2023 13:41
@tenthirtyam
Merge branch 'main' into feat/add-ping-connectivity
44c0dab 
Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@vmwclabot vmwclabot removed the dco-required DCO Required label May 2, 2023
@vmware vmware deleted a comment from vmwclabot May 2, 2023
GaryJBlake
GaryJBlake approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit b541226 into main May 2, 2023
@tenthirtyam tenthirtyam deleted the feat/add-ping-connectivity branch May 2, 2023 13:44
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryJBlake GaryJBlake GaryJBlake approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
enhancement Enhancement
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Add support for additional connectivity health checks
3 participants
@tenthirtyam @GaryJBlake @vmwclabot