Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Publish-NsxtTier0BgpStatus #134

Merged
merged 1 commit into from
May 3, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented May 2, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Updates Publish-NsxtTier0BgpStatus to format the HTML correctly in the event that $nsxtTier0BgpStatus.Count for a workload domain is not greater than 0.
  • Updates module version to v2.1.0.1006.
  • Updates the CHANGELOG.md.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Related #106

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Before:

image

After:

image

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added bug Bug report/overview Overview Report labels May 2, 2023
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone May 2, 2023
@tenthirtyam tenthirtyam self-assigned this May 2, 2023
@tenthirtyam tenthirtyam force-pushed the fix/nsx-tier0-bgp-status-css branch from 666961d to c4204b0 Compare May 2, 2023 20:48
@tenthirtyam tenthirtyam added report/health Health Report and removed report/overview Overview Report labels May 2, 2023
- Updates `Publish-NsxtTier0BgpStatus` to format the HTML correctly in the event that $nsxtTier0BgpStatus.Count for a workload domain is not greater than 0.
- Updates module version to v2.1.0.1006.
- Updates the `CHANGELOG.md`.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam force-pushed the fix/nsx-tier0-bgp-status-css branch from c4204b0 to 61029e5 Compare May 3, 2023 13:04
@tenthirtyam tenthirtyam marked this pull request as ready for review May 3, 2023 13:07
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 3, 2023 13:07
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 860a9a6 into main May 3, 2023
@GaryJBlake GaryJBlake deleted the fix/nsx-tier0-bgp-status-css branch May 3, 2023 13:08
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report/health Health Report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants