Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update nsx product terms #135

Merged
merged 1 commit into from
May 3, 2023
Merged

chore: update nsx product terms #135

merged 1 commit into from
May 3, 2023

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Updated "NSX-T Data Center" to "NSX" product name.
  • Updated "NSX Manager instance" to "NSX Manager cluster".
  • Updated "NSX Managers (Local)" to "NSX Local Managers".
  • Updated "from NSX Manager" to "from an NSX Manager".
  • Updated module version from v2.1.0.1006 to v2.1.0.1007.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe: chore

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added technical-debt Technical Debt chore Chore labels May 3, 2023
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone May 3, 2023
@tenthirtyam tenthirtyam self-assigned this May 3, 2023
@tenthirtyam
chore: update nsx product terms
962180c 
- Updated "NSX-T Data Center" to "NSX" product name.
- Updated "NSX Manager instance" to "NSX Manager cluster".
- Updated "NSX Managers (Local)" to "NSX Local Managers".
- Updated "from NSX Manager" to "from an NSX Manager".
- Updated module version from v2.1.0.1006 to v2.1.0.1007.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam force-pushed the chore/update-nsx-product-terms branch from 584d2cb to 962180c Compare May 3, 2023 13:49
@tenthirtyam tenthirtyam marked this pull request as ready for review May 3, 2023 13:49
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 3, 2023 13:49
GaryJBlake
GaryJBlake approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 53c6c04 into main May 3, 2023
@GaryJBlake GaryJBlake deleted the chore/update-nsx-product-terms branch May 3, 2023 13:57
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryJBlake GaryJBlake GaryJBlake approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
chore Chore technical-debt Technical Debt
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tenthirtyam @GaryJBlake