Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add check for cmdlet prerequisites #191

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Nov 16, 2023

Summary

Added a prerequisite check to Invoke-VcfHealthReport function to verify that the tar utility is present on Windows if using Windows PowerShell 5.1 (Desktop) or PowerShell 7 (Core).

The tar utility is included with Windows Server 2019 and later and is noted as a system requirement.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #190

Additional Information

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner November 16, 2023 18:42
@tenthirtyam tenthirtyam added the enhancement Enhancement label Nov 16, 2023
@tenthirtyam tenthirtyam added this to the v2.5.0 milestone Nov 16, 2023
@tenthirtyam tenthirtyam force-pushed the code/updated_-Invoke-VcfHealthReport_function branch from 7c00684 to 1f97012 Compare November 16, 2023 19:34
@tenthirtyam tenthirtyam changed the title :code/changed_VMware.CloudFoundation.Reporting.psm1_added feat: add check for cmdlet prerequisites Nov 16, 2023
Added a prerequisite check to `Invoke-VcfHealthReport` function to verify that the tar utility is present on Windows if using Windows PowerShell 5.1 (Desktop) or PowerShell 7 (Core).

The `tar` utility is included with Windows Server 2019 and later and is noted as a system requirement in the documentation.

Signed-off-by: Jared Burns <burnsja@vmware.com>
@tenthirtyam tenthirtyam force-pushed the code/updated_-Invoke-VcfHealthReport_function branch from 1f97012 to f398e16 Compare November 16, 2023 22:16
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a recheck for Invoke-VcfHealthReport to check for tar if running Windows
2 participants